* [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
@ 2019-10-17 12:19 David Hildenbrand
2019-10-17 12:20 ` David Hildenbrand
2019-10-17 14:18 ` Cornelia Huck
0 siblings, 2 replies; 4+ messages in thread
From: David Hildenbrand @ 2019-10-17 12:19 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Thomas Huth, Janosch Frank, David Hildenbrand,
Cornelia Huck, Richard Henderson, Halil Pasic,
Christian Borntraeger, qemu-s390x
No need to double-check if we have a write.
Found by Coverity (CID: 1381016).
Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/mmu_helper.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 90b81335f9..c9f3f34750 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,
*flags |= PAGE_WRITE_INV;
if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
/* LAP sets bit 56 */
- *tec = (raddr & TARGET_PAGE_MASK)
- | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
- | 0x80;
+ *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
return PGM_PROTECTION;
}
}
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
2019-10-17 12:19 [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE David Hildenbrand
@ 2019-10-17 12:20 ` David Hildenbrand
2019-10-17 13:14 ` Richard Henderson
2019-10-17 14:18 ` Cornelia Huck
1 sibling, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2019-10-17 12:20 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Thomas Huth, Janosch Frank, Cornelia Huck,
Richard Henderson, Halil Pasic, Christian Borntraeger, qemu-s390x
On 17.10.19 14:19, David Hildenbrand wrote:
> No need to double-check if we have a write.
>
> Found by Coverity (CID: 1381016).
Copy and past error, it's 1406404.
>
> Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/mmu_helper.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index 90b81335f9..c9f3f34750 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,
> *flags |= PAGE_WRITE_INV;
> if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
> /* LAP sets bit 56 */
> - *tec = (raddr & TARGET_PAGE_MASK)
> - | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
> - | 0x80;
> + *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
> return PGM_PROTECTION;
> }
> }
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
2019-10-17 12:20 ` David Hildenbrand
@ 2019-10-17 13:14 ` Richard Henderson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2019-10-17 13:14 UTC (permalink / raw)
To: David Hildenbrand, qemu-devel
Cc: Peter Maydell, Thomas Huth, Janosch Frank, Cornelia Huck,
Halil Pasic, Christian Borntraeger, qemu-s390x
On 10/17/19 5:20 AM, David Hildenbrand wrote:
> On 17.10.19 14:19, David Hildenbrand wrote:
>> No need to double-check if we have a write.
>>
>> Found by Coverity (CID: 1381016).
>
> Copy and past error, it's 1406404.
>
>>
>> Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
>> Cc: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
2019-10-17 12:19 [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE David Hildenbrand
2019-10-17 12:20 ` David Hildenbrand
@ 2019-10-17 14:18 ` Cornelia Huck
1 sibling, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2019-10-17 14:18 UTC (permalink / raw)
To: David Hildenbrand
Cc: Peter Maydell, Thomas Huth, Janosch Frank, Richard Henderson,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x
On Thu, 17 Oct 2019 14:19:22 +0200
David Hildenbrand <david@redhat.com> wrote:
> No need to double-check if we have a write.
>
> Found by Coverity (CID: 1381016).
>
> Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/mmu_helper.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index 90b81335f9..c9f3f34750 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,
> *flags |= PAGE_WRITE_INV;
> if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
> /* LAP sets bit 56 */
> - *tec = (raddr & TARGET_PAGE_MASK)
> - | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
> - | 0x80;
> + *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
> return PGM_PROTECTION;
> }
> }
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-17 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 12:19 [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE David Hildenbrand
2019-10-17 12:20 ` David Hildenbrand
2019-10-17 13:14 ` Richard Henderson
2019-10-17 14:18 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).