From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR
Date: Thu, 17 Oct 2019 15:31:32 +0200 [thread overview]
Message-ID: <20191017133155.5327-1-mreitz@redhat.com> (raw)
Hi,
Perhaps the main reason we cannot run important tests such as 041 in CI
is that when they care Unix sockets in $TEST_DIR, the path may become
too long to connect to them.
To get by this problem, this series lets the check script create a new
temporary directory (mktemp -d) and then makes the iotests use it for
all Unix sockets.
v2:
- Patch 1: Use mkdir -p
- Patches 4/23: Only add the $SOCK_DIR replacement line in patch 4 and
only drop the $TEST_DIR line in patch 23
(Took Eric’s R-b on both because that’s how I interpreted his
comments)
git-backport-diff against v2:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/23:[0010] [FC] 'iotests: Introduce $SOCK_DIR'
002/23:[----] [--] 'iotests.py: Store socket files in $SOCK_DIR'
003/23:[----] [--] 'iotests.py: Add @base_dir to FilePaths etc.'
004/23:[0002] [FC] 'iotests: Filter $SOCK_DIR'
005/23:[----] [--] 'iotests: Let common.nbd create socket in $SOCK_DIR'
006/23:[----] [--] 'iotests/083: Create socket in $SOCK_DIR'
007/23:[----] [--] 'iotests/140: Create socket in $SOCK_DIR'
008/23:[----] [--] 'iotests/143: Create socket in $SOCK_DIR'
009/23:[----] [--] 'iotests/147: Create socket in $SOCK_DIR'
010/23:[----] [--] 'iotests/181: Create socket in $SOCK_DIR'
011/23:[----] [--] 'iotests/182: Create socket in $SOCK_DIR'
012/23:[----] [--] 'iotests/183: Create socket in $SOCK_DIR'
013/23:[----] [--] 'iotests/192: Create socket in $SOCK_DIR'
014/23:[----] [--] 'iotests/194: Create sockets in $SOCK_DIR'
015/23:[----] [--] 'iotests/201: Create socket in $SOCK_DIR'
016/23:[----] [--] 'iotests/205: Create socket in $SOCK_DIR'
017/23:[----] [--] 'iotests/208: Create socket in $SOCK_DIR'
018/23:[----] [--] 'iotests/209: Create socket in $SOCK_DIR'
019/23:[----] [--] 'iotests/222: Create socket in $SOCK_DIR'
020/23:[----] [--] 'iotests/223: Create socket in $SOCK_DIR'
021/23:[----] [--] 'iotests/240: Create socket in $SOCK_DIR'
022/23:[----] [--] 'iotests/267: Create socket in $SOCK_DIR'
023/23:[0002] [FC] 'iotests: Drop TEST_DIR filter from _filter_nbd'
Max Reitz (23):
iotests: Introduce $SOCK_DIR
iotests.py: Store socket files in $SOCK_DIR
iotests.py: Add @base_dir to FilePaths etc.
iotests: Filter $SOCK_DIR
iotests: Let common.nbd create socket in $SOCK_DIR
iotests/083: Create socket in $SOCK_DIR
iotests/140: Create socket in $SOCK_DIR
iotests/143: Create socket in $SOCK_DIR
iotests/147: Create socket in $SOCK_DIR
iotests/181: Create socket in $SOCK_DIR
iotests/182: Create socket in $SOCK_DIR
iotests/183: Create socket in $SOCK_DIR
iotests/192: Create socket in $SOCK_DIR
iotests/194: Create sockets in $SOCK_DIR
iotests/201: Create socket in $SOCK_DIR
iotests/205: Create socket in $SOCK_DIR
iotests/208: Create socket in $SOCK_DIR
iotests/209: Create socket in $SOCK_DIR
iotests/222: Create socket in $SOCK_DIR
iotests/223: Create socket in $SOCK_DIR
iotests/240: Create socket in $SOCK_DIR
iotests/267: Create socket in $SOCK_DIR
iotests: Drop TEST_DIR filter from _filter_nbd
python/qemu/machine.py | 15 +++++++++++---
python/qemu/qtest.py | 9 ++++++---
tests/qemu-iotests/083 | 6 +++---
tests/qemu-iotests/083.out | 34 ++++++++++++++++----------------
tests/qemu-iotests/140 | 8 ++++----
tests/qemu-iotests/140.out | 2 +-
tests/qemu-iotests/143 | 6 +++---
tests/qemu-iotests/143.out | 2 +-
tests/qemu-iotests/147 | 2 +-
tests/qemu-iotests/181 | 2 +-
tests/qemu-iotests/182 | 4 ++--
tests/qemu-iotests/183 | 2 +-
tests/qemu-iotests/192 | 4 ++--
tests/qemu-iotests/192.out | 2 +-
tests/qemu-iotests/194 | 4 ++--
tests/qemu-iotests/201 | 2 +-
tests/qemu-iotests/205 | 2 +-
tests/qemu-iotests/208 | 2 +-
tests/qemu-iotests/209 | 3 ++-
tests/qemu-iotests/222 | 2 +-
tests/qemu-iotests/223 | 14 ++++++-------
tests/qemu-iotests/240 | 4 ++--
tests/qemu-iotests/241 | 2 --
tests/qemu-iotests/267 | 4 ++--
tests/qemu-iotests/267.out | 2 +-
tests/qemu-iotests/check | 15 ++++++++++++--
tests/qemu-iotests/common.filter | 7 +++++--
tests/qemu-iotests/common.nbd | 2 +-
tests/qemu-iotests/iotests.py | 16 ++++++++-------
29 files changed, 103 insertions(+), 76 deletions(-)
--
2.21.0
next reply other threads:[~2019-10-17 14:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:31 Max Reitz [this message]
2019-10-17 13:31 ` [PATCH v2 01/23] iotests: Introduce $SOCK_DIR Max Reitz
2019-10-17 14:52 ` Eric Blake
2019-10-18 9:03 ` Max Reitz
2019-10-18 13:30 ` Eric Blake
2019-10-17 13:31 ` [PATCH v2 02/23] iotests.py: Store socket files in $SOCK_DIR Max Reitz
2019-10-17 13:31 ` [PATCH v2 03/23] iotests.py: Add @base_dir to FilePaths etc Max Reitz
2019-10-17 13:31 ` [PATCH v2 04/23] iotests: Filter $SOCK_DIR Max Reitz
2019-10-17 15:50 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 05/23] iotests: Let common.nbd create socket in $SOCK_DIR Max Reitz
2019-10-17 15:52 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 06/23] iotests/083: Create " Max Reitz
2019-10-17 13:31 ` [PATCH v2 07/23] iotests/140: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 08/23] iotests/143: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 09/23] iotests/147: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 10/23] iotests/181: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 11/23] iotests/182: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 12/23] iotests/183: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 13/23] iotests/192: " Max Reitz
2019-10-17 15:53 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 14/23] iotests/194: Create sockets " Max Reitz
2019-10-17 13:31 ` [PATCH v2 15/23] iotests/201: Create socket " Max Reitz
2019-10-17 15:55 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 16/23] iotests/205: " Max Reitz
2019-10-17 15:56 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 17/23] iotests/208: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 18/23] iotests/209: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 19/23] iotests/222: " Max Reitz
2019-10-17 13:31 ` [PATCH v2 20/23] iotests/223: " Max Reitz
2019-10-17 15:57 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 21/23] iotests/240: " Max Reitz
2019-10-17 15:57 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 22/23] iotests/267: " Max Reitz
2019-10-17 15:58 ` Thomas Huth
2019-10-17 13:31 ` [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd Max Reitz
2019-10-17 15:58 ` Thomas Huth
2019-10-17 14:59 ` [PATCH v2 00/23] iotests: Add and use $SOCK_DIR Eric Blake
2019-10-18 16:02 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017133155.5327-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).