* [PATCH] s390x/cpumodel: Add missing visit_free
@ 2019-10-16 14:54 Andrew Jones
2019-10-16 16:54 ` David Hildenbrand
2019-10-17 11:44 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jones @ 2019-10-16 14:54 UTC (permalink / raw)
To: qemu-devel, qemu-s390x; +Cc: pasic, borntraeger, cohuck, david
Beata Michalska noticed this missing visit_free() while reviewing
arm's implementation of qmp_query_cpu_model_expansion(), which is
modeled off this s390x implementation.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
target/s390x/cpu_models.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 009afc38b92d..7e92fb2e156d 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
visitor = qobject_input_visitor_new(info->props);
visit_start_struct(visitor, NULL, NULL, 0, errp);
if (*errp) {
+ visit_free(visitor);
object_unref(obj);
return;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390x/cpumodel: Add missing visit_free
2019-10-16 14:54 [PATCH] s390x/cpumodel: Add missing visit_free Andrew Jones
@ 2019-10-16 16:54 ` David Hildenbrand
2019-10-17 11:44 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2019-10-16 16:54 UTC (permalink / raw)
To: Andrew Jones, qemu-devel, qemu-s390x; +Cc: pasic, borntraeger, cohuck
On 16.10.19 16:54, Andrew Jones wrote:
> Beata Michalska noticed this missing visit_free() while reviewing
> arm's implementation of qmp_query_cpu_model_expansion(), which is
> modeled off this s390x implementation.
Nice to see ARM support getting added.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> target/s390x/cpu_models.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 009afc38b92d..7e92fb2e156d 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
> visitor = qobject_input_visitor_new(info->props);
> visit_start_struct(visitor, NULL, NULL, 0, errp);
> if (*errp) {
> + visit_free(visitor);
> object_unref(obj);
> return;
> }
>
Right, thanks
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390x/cpumodel: Add missing visit_free
2019-10-16 14:54 [PATCH] s390x/cpumodel: Add missing visit_free Andrew Jones
2019-10-16 16:54 ` David Hildenbrand
@ 2019-10-17 11:44 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2019-10-17 11:44 UTC (permalink / raw)
To: Andrew Jones; +Cc: pasic, borntraeger, qemu-s390x, qemu-devel, david
On Wed, 16 Oct 2019 16:54:34 +0200
Andrew Jones <drjones@redhat.com> wrote:
> Beata Michalska noticed this missing visit_free() while reviewing
> arm's implementation of qmp_query_cpu_model_expansion(), which is
> modeled off this s390x implementation.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> target/s390x/cpu_models.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 009afc38b92d..7e92fb2e156d 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
> visitor = qobject_input_visitor_new(info->props);
> visit_start_struct(visitor, NULL, NULL, 0, errp);
> if (*errp) {
> + visit_free(visitor);
> object_unref(obj);
> return;
> }
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 14:54 [PATCH] s390x/cpumodel: Add missing visit_free Andrew Jones
2019-10-16 16:54 ` David Hildenbrand
2019-10-17 11:44 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).