* [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386
@ 2019-10-17 16:26 Philippe Mathieu-Daudé
2019-10-22 16:48 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-17 16:26 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel, Markus Armbruster
Cc: Paolo Bonzini, Philippe Mathieu-Daudé, Michael S. Tsirkin
Commit a6c7040fb09 restricted the rtc-reset-reinjection command
to the I386 target.
Restrict the "qapi/qapi-commands-misc-target.h" header to it too.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/timer/mc146818rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 6cb378751b..c1eb0a7376 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -37,12 +37,12 @@
#include "hw/timer/mc146818rtc.h"
#include "migration/vmstate.h"
#include "qapi/error.h"
-#include "qapi/qapi-commands-misc-target.h"
#include "qapi/qapi-events-misc-target.h"
#include "qapi/visitor.h"
#include "exec/address-spaces.h"
#ifdef TARGET_I386
+#include "qapi/qapi-commands-misc-target.h"
#include "hw/i386/apic.h"
#endif
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386
2019-10-17 16:26 [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386 Philippe Mathieu-Daudé
@ 2019-10-22 16:48 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-10-22 16:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Marc-André Lureau, qemu-devel,
Markus Armbruster
Cc: Michael S. Tsirkin
On 17/10/19 18:26, Philippe Mathieu-Daudé wrote:
> Commit a6c7040fb09 restricted the rtc-reset-reinjection command
> to the I386 target.
> Restrict the "qapi/qapi-commands-misc-target.h" header to it too.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/mc146818rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 6cb378751b..c1eb0a7376 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -37,12 +37,12 @@
> #include "hw/timer/mc146818rtc.h"
> #include "migration/vmstate.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands-misc-target.h"
> #include "qapi/qapi-events-misc-target.h"
> #include "qapi/visitor.h"
> #include "exec/address-spaces.h"
>
> #ifdef TARGET_I386
> +#include "qapi/qapi-commands-misc-target.h"
> #include "hw/i386/apic.h"
> #endif
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 16:26 [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386 Philippe Mathieu-Daudé
2019-10-22 16:48 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).