qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH v7 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state
Date: Thu, 17 Oct 2019 11:50:50 -0700	[thread overview]
Message-ID: <20191017185110.539-1-richard.henderson@linaro.org> (raw)

Changes since v6:
  * Regen hflags in two more places for m-profile (patch 19).

Changes since v5:
  * Fix the debug assertion ifdef in the final patch.
  * Add more calls to arm_rebuild_hflags: CPSR and M-profile
    These become two new patches, 18 & 19.
  * Update some comments per review. (Alex)

Changes since v4:
  * Split patch 1 into 15 smaller patches.
  * Cache the new DEBUG_TARGET_EL field.
  * Split out m-profile hflags separately from a-profile 32-bit.
  * Move around non-cached tb flags as well, avoiding repetitive
    checks for m-profile or other mutually exclusive conditions.

  I haven't officially re-run the performance test quoted in the
  last patch, but I have eyeballed "perf top", and have dug into
  the compiled code a bit, which resulted in a few of the new
  cleanup patches (e.g. cs_base, arm_mmu_idx_el, and
  arm_cpu_data_is_big_endian).
...


r~


Richard Henderson (20):
  target/arm: Split out rebuild_hflags_common
  target/arm: Split out rebuild_hflags_a64
  target/arm: Split out rebuild_hflags_common_32
  target/arm: Split arm_cpu_data_is_big_endian
  target/arm: Split out rebuild_hflags_m32
  target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state
  target/arm: Split out rebuild_hflags_a32
  target/arm: Split out rebuild_hflags_aprofile
  target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in
    cpu_get_tb_cpu_state
  target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state
  target/arm: Hoist computation of TBFLAG_A32.VFPEN
  target/arm: Add arm_rebuild_hflags
  target/arm: Split out arm_mmu_idx_el
  target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state
  target/arm: Add HELPER(rebuild_hflags_{a32,a64,m32})
  target/arm: Rebuild hflags at EL changes
  target/arm: Rebuild hflags at MSR writes
  target/arm: Rebuild hflags at CPSR writes
  target/arm: Rebuild hflags for M-profile.
  target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

 target/arm/cpu.h           |  84 +++++---
 target/arm/helper.h        |   4 +
 target/arm/internals.h     |   9 +
 hw/intc/armv7m_nvic.c      |   1 +
 linux-user/syscall.c       |   1 +
 target/arm/cpu.c           |   1 +
 target/arm/helper-a64.c    |   3 +
 target/arm/helper.c        | 383 ++++++++++++++++++++++++-------------
 target/arm/m_helper.c      |   6 +
 target/arm/machine.c       |   1 +
 target/arm/op_helper.c     |   4 +
 target/arm/translate-a64.c |  13 +-
 target/arm/translate.c     |  33 +++-
 13 files changed, 368 insertions(+), 175 deletions(-)

-- 
2.17.1



             reply	other threads:[~2019-10-17 18:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17 18:50 Richard Henderson [this message]
2019-10-17 18:50 ` [PATCH v7 01/20] target/arm: Split out rebuild_hflags_common Richard Henderson
2019-10-17 18:50 ` [PATCH v7 02/20] target/arm: Split out rebuild_hflags_a64 Richard Henderson
2019-10-17 18:50 ` [PATCH v7 03/20] target/arm: Split out rebuild_hflags_common_32 Richard Henderson
2019-10-17 18:50 ` [PATCH v7 04/20] target/arm: Split arm_cpu_data_is_big_endian Richard Henderson
2019-10-17 18:50 ` [PATCH v7 05/20] target/arm: Split out rebuild_hflags_m32 Richard Henderson
2019-10-17 18:50 ` [PATCH v7 06/20] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state Richard Henderson
2019-10-17 18:50 ` [PATCH v7 07/20] target/arm: Split out rebuild_hflags_a32 Richard Henderson
2019-10-17 18:50 ` [PATCH v7 08/20] target/arm: Split out rebuild_hflags_aprofile Richard Henderson
2019-10-17 18:50 ` [PATCH v7 09/20] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state Richard Henderson
2019-10-17 18:51 ` [PATCH v7 10/20] target/arm: Simplify set of PSTATE_SS " Richard Henderson
2019-10-17 18:51 ` [PATCH v7 11/20] target/arm: Hoist computation of TBFLAG_A32.VFPEN Richard Henderson
2019-10-17 18:51 ` [PATCH v7 12/20] target/arm: Add arm_rebuild_hflags Richard Henderson
2019-10-17 18:51 ` [PATCH v7 13/20] target/arm: Split out arm_mmu_idx_el Richard Henderson
2019-10-17 18:51 ` [PATCH v7 14/20] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state Richard Henderson
2019-10-17 18:51 ` [PATCH v7 15/20] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}) Richard Henderson
2019-10-17 18:51 ` [PATCH v7 16/20] target/arm: Rebuild hflags at EL changes Richard Henderson
2019-10-17 18:51 ` [PATCH v7 17/20] target/arm: Rebuild hflags at MSR writes Richard Henderson
2019-10-18 12:32   ` Peter Maydell
2019-10-18 14:30     ` Richard Henderson
2019-10-18 14:49       ` Peter Maydell
2019-10-17 18:51 ` [PATCH v7 18/20] target/arm: Rebuild hflags at CPSR writes Richard Henderson
2019-10-17 18:51 ` [PATCH v7 19/20] target/arm: Rebuild hflags for M-profile Richard Henderson
2019-10-18 12:25   ` Peter Maydell
2019-10-18 14:31     ` Richard Henderson
2019-10-18 14:52       ` Peter Maydell
2019-10-18 14:55         ` Peter Maydell
2019-10-17 18:51 ` [PATCH v7 20/20] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017185110.539-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).