From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A11CA9EA1 for ; Fri, 18 Oct 2019 08:21:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AF4921925 for ; Fri, 18 Oct 2019 08:21:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF4921925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLNVg-000438-Mj for qemu-devel@archiver.kernel.org; Fri, 18 Oct 2019 04:21:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37131) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLNQG-0006KE-5d for qemu-devel@nongnu.org; Fri, 18 Oct 2019 04:15:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLNQE-0007pP-Ti for qemu-devel@nongnu.org; Fri, 18 Oct 2019 04:15:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLNQE-0007oe-Nl for qemu-devel@nongnu.org; Fri, 18 Oct 2019 04:15:42 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 469B4307D941; Fri, 18 Oct 2019 08:15:41 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-198.ams2.redhat.com [10.36.117.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE5755C22F; Fri, 18 Oct 2019 08:15:37 +0000 (UTC) Date: Fri, 18 Oct 2019 10:15:36 +0200 From: Kevin Wolf To: John Snow Subject: Re: [PATCH] configure: Require Python >= 3.5 Message-ID: <20191018081536.GB6122@localhost.localdomain> References: <20191016224237.26180-1-ehabkost@redhat.com> <7146bebf-6e99-f27a-3753-d48dea1977f9@redhat.com> <20191017112121.GA9233@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 18 Oct 2019 08:15:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Cleber Rosa , Eduardo Habkost , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 17.10.2019 um 21:39 hat John Snow geschrieben: > On 10/17/19 7:21 AM, Kevin Wolf wrote: > > Am 17.10.2019 um 00:48 hat John Snow geschrieben: > >> On 10/16/19 6:42 PM, Eduardo Habkost wrote: > >>> Python 3.5 is the oldest Python version available on our > >>> supported build platforms, and Python 2 end of life will be 3 > >>> weeks after the planned release date of QEMU 4.2.0. Drop Python > >>> 2 support from configure completely, and require Python 3.5 or > >>> newer. > >>> > >>> Signed-off-by: Eduardo Habkost > >> > >> Seems like a good time and place to mention this. Kevin, you require > >> 3.6+ for iotests, which are -- at present -- invoked as part of "make > >> check". > >> > >> Do we care? Basically, this just means that iotests won't run for > >> systems that don't have 3.6+, which would be platforms like Debian 9 -- > >> which is why ehabkost is choosing 3.5 here. > > > > I think we were aware of this when we made the change to iotests. That > > all tests of the current upstream QEMU version are run on Debian > > oldstable (with the distro Python version) is, to say the least, not a > > priority for me. They must not fail, but I'd say skipping is fine. > > > > And actually, we should still have a reasonable coverage there with the > > shell-based test cases. > > This seems like a weirdly arbitrary decision for a benefit that's not > clear to me. Is it because you want variable annotations? Yes, the discussion about type annotations is what made me check whether we could do 3.6, because if we want to make use of type checking, we'll need it for both functions and variables to get reasonable results. And actually, we currently don't have any Python tests in the auto group, so the only effect is for people manually running ./check on Debian oldstable. I'm not sure, but I suspect this might be the empty set. Kevin