From: Stefan Hajnoczi <stefanha@gmail.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: virtio-fs@redhat.com,
Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation
Date: Fri, 18 Oct 2019 11:09:09 +0100 [thread overview]
Message-ID: <20191018100909.GB9360@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAOssrKdbAT5s=CYG6PBtE6OYdqgwG8vp9T6QMJpwZ7X3tKjPmg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Fri, Oct 18, 2019 at 09:16:36AM +0200, Miklos Szeredi wrote:
> On Thu, Oct 17, 2019 at 6:48 PM Miklos Szeredi <mszeredi@redhat.com> wrote:
>
> > Even simpler: allow O_PATH descriptors for f*xattr().
>
> Attached patch. Will post shortly.
>
> However, I think it would make sense to fix virtiofsd as well, as this
> will take time to percolate down, even if Al doesn't find anything
> wrong with it.
>
> Doing unshare(CLONE_FS) after thread startup seems safe, though must
> be careful to change the working directory to the root of the mount
> *before* starting any threads.
Thank you for extending O_PATH, that's great! This will be the cleanest
way to perform xattr operations.
If your patch is accepted I will send a man-pages.git patch to update
the open(2) O_PATH documentation (with a minimum kernel version).
I've added the unshare(CLONE_FS) task to my todo list in case no one
else gets to it first. I may not have time to work on it before
Novemeber though.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-10-18 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:37 [PATCH 0/2] virtiofsd: Two fix for xattr operation Misono Tomohiro
2019-10-16 10:37 ` [PATCH 1/2] virtiofsd: Avoid process hang when doing xattr operation to FIFO Misono Tomohiro
2019-10-16 10:37 ` [PATCH 2/2] virtiofsd: Allow setxattr operation to directry Misono Tomohiro
2019-10-17 10:05 ` [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation Stefan Hajnoczi
2019-10-17 11:23 ` Miklos Szeredi
2019-10-17 13:01 ` Miklos Szeredi
2019-10-17 15:25 ` Vivek Goyal
2019-10-17 15:45 ` Miklos Szeredi
2019-10-17 16:09 ` Stefan Hajnoczi
2019-10-17 16:48 ` Miklos Szeredi
2019-10-18 7:16 ` Miklos Szeredi
2019-10-18 8:51 ` misono.tomohiro
2019-10-21 9:40 ` Stefan Hajnoczi
2019-10-23 11:42 ` misono.tomohiro
2019-10-25 12:54 ` Stefan Hajnoczi
2019-10-18 10:09 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018100909.GB9360@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).