From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Corey Minyard" <cminyard@mvista.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Fabien Chouteau" <chouteau@adacore.com>,
qemu-arm@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-ppc@nongnu.org,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH 00/14] Clean-ups: remove QDEV_PROP_PTR
Date: Fri, 18 Oct 2019 17:41:58 +0200 [thread overview]
Message-ID: <20191018154212.13458-1-marcandre.lureau@redhat.com> (raw)
Hi,
QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove
me". In most cases, it can be easily replaced with QDEV_PROP_LINK when
the pointer points to an Object.
There are a few places where such substitution isn't possible. For
those places, it seems reasonable to use a specific setter method
instead, and keep the user_creatable = false. It is the case for OMAP
clocks, and smbus-eeprom initial data pointer. Improving that
situation is left for a future improvement.
Marc-André Lureau (14):
sm501: replace PROP_PTR with PROP_LINK
vmmouse: replace PROP_PTR with PROP_LINK
lance: replace PROP_PTR with PROP_LINK
etraxfs: remove PROP_PTR usage
dp8393x: replace PROP_PTR with PROP_LINK
leon3: replace PROP_PTR with PROP_LINK
RFC: mips/cps: fix setting saar property
cris: replace PROP_PTR with PROP_LINK for interrupt vector
smbus-eeprom: remove PROP_PTR
omap-intc: remove PROP_PTR
omap-i2c: remove PROP_PTR
omap-gpio: remove PROP_PTR
qdev: remove PROP_MEMORY_REGION
Remove QDEV_PROP_PTR
hw/arm/omap1.c | 8 +++----
hw/arm/omap2.c | 25 ++++++++++-----------
hw/core/qdev-properties.c | 18 ----------------
hw/cris/axis_dev88.c | 4 +---
hw/display/sm501.c | 5 +++--
hw/dma/sparc32_dma.c | 2 +-
hw/gpio/omap_gpio.c | 42 +++++++++++++-----------------------
hw/i2c/omap_i2c.c | 19 ++++++++++------
hw/i2c/smbus_eeprom.c | 17 +++++++--------
hw/i386/pc.c | 6 +++---
hw/i386/vmmouse.c | 8 +++----
hw/input/pckbd.c | 8 +++----
hw/intc/Makefile.objs | 2 +-
hw/intc/etraxfs_pic.c | 18 ++++++----------
hw/intc/grlib_irqmp.c | 20 ++++++-----------
hw/intc/omap_intc.c | 17 +++++++++------
hw/mips/cps.c | 2 +-
hw/mips/mips_jazz.c | 3 ++-
hw/net/dp8393x.c | 7 +++---
hw/net/etraxfs_eth.c | 35 ++++++++++++++++++++----------
hw/net/lance.c | 5 ++---
hw/net/pcnet-pci.c | 2 +-
hw/net/pcnet.h | 2 +-
hw/sh4/r2d.c | 3 ++-
hw/sparc/leon3.c | 7 +++---
include/hw/arm/omap.h | 36 +++++++++++++++++++++++++++++++
include/hw/cris/etraxfs.h | 20 +++--------------
include/hw/input/i8042.h | 4 +++-
include/hw/qdev-properties.h | 24 ---------------------
target/sparc/cpu.h | 1 +
30 files changed, 172 insertions(+), 198 deletions(-)
--
2.23.0.606.g08da6496b6
next reply other threads:[~2019-10-18 15:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 15:41 Marc-André Lureau [this message]
2019-10-18 15:41 ` [PATCH 01/14] sm501: replace PROP_PTR with PROP_LINK Marc-André Lureau
2019-10-18 16:22 ` Peter Maydell
2019-10-18 16:36 ` Marc-André Lureau
2019-10-18 16:50 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 02/14] vmmouse: " Marc-André Lureau
2019-10-21 10:10 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 03/14] lance: " Marc-André Lureau
2019-10-21 10:05 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 04/14] etraxfs: remove PROP_PTR usage Marc-André Lureau
2019-10-18 15:59 ` Peter Maydell
2019-10-18 16:11 ` Marc-André Lureau
2019-10-18 16:34 ` Peter Maydell
2019-10-21 10:41 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 05/14] dp8393x: replace PROP_PTR with PROP_LINK Marc-André Lureau
2019-10-18 17:49 ` Peter Maydell
2019-10-18 18:14 ` Aleksandar Markovic
2019-10-18 15:42 ` [PATCH 06/14] leon3: " Marc-André Lureau
2019-10-18 17:45 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 07/14] RFC: mips/cps: fix setting saar property Marc-André Lureau
2019-10-18 17:04 ` Philippe Mathieu-Daudé
2019-10-18 17:42 ` Aleksandar Markovic
2019-10-18 15:42 ` [PATCH 08/14] cris: replace PROP_PTR with PROP_LINK for interrupt vector Marc-André Lureau
2019-10-18 17:37 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 09/14] smbus-eeprom: remove PROP_PTR Marc-André Lureau
2019-10-18 17:20 ` Peter Maydell
2019-10-21 14:52 ` Corey Minyard
2019-10-21 21:28 ` Marc-André Lureau
2019-10-18 15:42 ` [PATCH 10/14] omap-intc: " Marc-André Lureau
2019-10-18 16:55 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 11/14] omap-i2c: " Marc-André Lureau
2019-10-18 16:56 ` Peter Maydell
2019-10-21 15:03 ` Corey Minyard
2019-10-18 15:42 ` [PATCH 12/14] omap-gpio: " Marc-André Lureau
2019-10-18 16:58 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 13/14] qdev: remove PROP_MEMORY_REGION Marc-André Lureau
2019-10-18 16:58 ` Peter Maydell
2019-10-18 15:42 ` [PATCH 14/14] Remove QDEV_PROP_PTR Marc-André Lureau
2019-10-18 16:59 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018154212.13458-1-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=chouteau@adacore.com \
--cc=cminyard@mvista.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).