From: Thomas Huth <huth@tuxfamily.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Michael Walle <michael@walle.cc>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Magnus Damm <magnus.damm@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 7/8] hw/m68k/mcf5206.c: Switch to transaction-based ptimer API
Date: Sat, 19 Oct 2019 13:10:27 +0200 [thread overview]
Message-ID: <20191019131027.018dc911@thl530> (raw)
In-Reply-To: <20191019124859.6a85e220@thl530>
Am Sat, 19 Oct 2019 12:48:59 +0200
schrieb Thomas Huth <huth@tuxfamily.org>:
> Am Thu, 17 Oct 2019 14:29:04 +0100
> schrieb Peter Maydell <peter.maydell@linaro.org>:
>
> > Switch the mcf5206 code away from bottom-half based ptimers to
> > the new transaction-based ptimer API. This just requires adding
> > begin/commit calls around the various places that modify the ptimer
> > state, and using the new ptimer_init() function to create the timer.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > hw/m68k/mcf5206.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
>
> After applying the patch, I now get an assertion:
>
> $ qemu-system-m68k -nographic -kernel
> ~/tmp/images/image-an5206-big-20000706.bin -M an5206
>
> uClinux/COLDFIRE(m5206)
> COLDFIRE port done by Greg Ungerer, gerg@moreton.com.au
> Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne
> KERNEL -> TEXT=0x010000-0x077cb8 DATA=0x077cb8-0x08b0d0
> BSS=0x08b0d0-0x0a2d58 KERNEL -> ROMFS=0x0a2d58-0x183b10
> MEM=0x183b10-0x1fff000 STACK=0x1fff000-0x2000000 qemu-system-m68k:
> hw/core/ptimer.c:410: ptimer_transaction_begin: Assertion
> `!s->in_transaction || !s->callback' failed.
>
> Looks like something is still wrong here...
FWIW, the image for testing can be found here:
https://web.archive.org/web/20181018135822/http://www.uclinux.org/ports/coldfire/image-an5206-big-20000706.bin.gz
Thomas
next prev parent reply other threads:[~2019-10-19 11:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:28 [PATCH 0/8] Convert misc-arch devices to new ptimer API Peter Maydell
2019-10-17 13:28 ` [PATCH 1/8] hw/timer/puv3_ost.c: Switch to transaction-based " Peter Maydell
2019-10-17 14:26 ` Richard Henderson
2019-10-17 15:59 ` Philippe Mathieu-Daudé
2019-10-17 13:28 ` [PATCH 2/8] hw/timer/sh_timer: " Peter Maydell
2019-10-17 14:49 ` Richard Henderson
2019-10-17 16:01 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 3/8] hw/timer/lm32_timer: " Peter Maydell
2019-10-17 14:51 ` Richard Henderson
2019-10-17 16:10 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 4/8] hw/watchdog/milkymist-sysctl.c: " Peter Maydell
2019-10-17 14:52 ` Richard Henderson
2019-10-17 15:42 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 5/8] hw/timer/altera_timer.c: " Peter Maydell
2019-10-17 15:02 ` Richard Henderson
2019-10-17 16:09 ` Philippe Mathieu-Daudé
2019-10-17 16:10 ` Peter Maydell
2019-10-17 13:29 ` [PATCH 6/8] hw/watchdog/etraxfs_timer.c: " Peter Maydell
2019-10-17 15:06 ` Richard Henderson
2019-10-17 15:47 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 7/8] hw/m68k/mcf5206.c: " Peter Maydell
2019-10-17 15:07 ` Richard Henderson
2019-10-17 15:48 ` Philippe Mathieu-Daudé
2019-10-19 10:48 ` Thomas Huth
2019-10-19 11:10 ` Thomas Huth [this message]
2019-10-19 11:38 ` Thomas Huth
2019-10-17 13:29 ` [PATCH 8/8] hw/m68k/mcf5208.c: " Peter Maydell
2019-10-17 15:08 ` Richard Henderson
2019-10-17 15:49 ` Philippe Mathieu-Daudé
2019-10-19 10:52 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019131027.018dc911@thl530 \
--to=huth@tuxfamily.org \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).