From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>
Subject: Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes
Date: Mon, 21 Oct 2019 12:01:25 +0200 [thread overview]
Message-ID: <20191021120125.19ca110f.cohuck@redhat.com> (raw)
In-Reply-To: <6404748d-1711-b6d7-f13b-10250d74dc92@redhat.com>
On Mon, 21 Oct 2019 11:58:35 +0200
David Hildenbrand <david@redhat.com> wrote:
> > query-machines probes with the "none" machine all other machines.
> > Current code only fixes up the active machine.
> >
>
> To be more precise, libvirt probes with "-machine none,accel=kvm:tcg"
> all other machines.
Add that to the patch description?
>
> > (that's why you won't notice when starting a machine - you will always
> > get "host" for the active one)
> >
> >>
> >> Anyway, your patch sounds fine, so (with "klass" replaced by "oc"):
Respin with that? Makes it easier to pick up :)
> >>
> >> Reviewed-by: Thomas Huth <thuth@redhat.com>
> >>
> >
> >
>
>
prev parent reply other threads:[~2019-10-21 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 9:34 [PATCH v1] s390x/kvm: Set default cpu model for all machine classes David Hildenbrand
2019-10-21 9:52 ` Thomas Huth
2019-10-21 9:54 ` David Hildenbrand
2019-10-21 9:58 ` Thomas Huth
2019-10-21 9:58 ` David Hildenbrand
2019-10-21 10:01 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021120125.19ca110f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).