From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2726CA9EAF for ; Mon, 21 Oct 2019 16:06:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA81F2173B for ; Mon, 21 Oct 2019 16:06:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a0tFnv1o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA81F2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMaCX-0005JK-GR for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 12:06:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33821) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMa8M-00011T-2N for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMa8J-0002fa-R4 for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:02:12 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:39955 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMa8J-0002ef-GM for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571673730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o2O9ikDTM+eojr3daTosbTUIXWyqIj2tZgfsnLa8Onc=; b=a0tFnv1oEETUBG6vA44BAoUSzxApZiWSkQUDfKP/YNBFLFG/APKCJ3FlnBzf5Vtl5QkInw c9feFYpxGTsho6Aw3GyIVJxeOXrleAw7CsrxE15Vyp+18KwmfxYjxc87BwXjnGOLJM+ZLp As4134c45PyKqOztS+nAPtQLUTp8GCs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-LHuaHmN1NvatrKLM8VLChQ-1; Mon, 21 Oct 2019 12:02:07 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BAACF800D41; Mon, 21 Oct 2019 16:02:00 +0000 (UTC) Received: from gondolin (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D157196AE; Mon, 21 Oct 2019 16:01:54 +0000 (UTC) Date: Mon, 21 Oct 2019 18:01:52 +0200 From: Cornelia Huck To: David Hildenbrand Subject: Re: [PATCH v2 0/6] s390x/tcg: Vector instruction fixes Message-ID: <20191021180152.78fa879d.cohuck@redhat.com> In-Reply-To: <20191021085715.3797-1-david@redhat.com> References: <20191021085715.3797-1-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: LHuaHmN1NvatrKLM8VLChQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Ivan Warren , qemu-s390x@nongnu.org, Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 21 Oct 2019 10:57:09 +0200 David Hildenbrand wrote: > Ivan reported that a simple > $ go get -v -d github.com/FactomProject/factom >=20 > Will result in errors when vector instructions are in use. Turns out > golang makes excessive use of vector instructions, e.g., for crypto, hash= es > but also basic math. >=20 > I tracked the involved vector instructions and started writing more > tests for them (will upstream them once they are in a better shape). Turn= s > out there are quite some issues remaining. golang uses instructions not > yet used by the kernel or by glibc. >=20 > With these patches, "go get" works again. It wouldn't surprise me if ther= e > are more BUGs in the vector instructions. Will continue writing more test= s. >=20 > Cc: Ivan Warren >=20 > v1 -> v2: > - "s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION" > -- Fix by inverting the result > - "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION" > -- Reuse gen_ac2_i64() > - "s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION" > -- Reuse gen_accc2_i64() > - Ran against more tests >=20 > David Hildenbrand (6): > s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD > s390x/tcg: Fix VECTOR MULTIPLY AND ADD * > s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE > s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION > s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION > s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION >=20 > target/s390x/translate_vx.inc.c | 30 ++++++++++++------------------ > target/s390x/vec_int_helper.c | 18 ++++++++++-------- > 2 files changed, 22 insertions(+), 26 deletions(-) >=20 Thanks, applied.