* [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript
@ 2019-10-21 21:41 Eduardo Habkost
2019-10-23 15:41 ` John Snow
2019-11-05 15:36 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2019-10-21 21:41 UTC (permalink / raw)
To: qemu-devel
Cc: John Snow, Philippe Mathieu-Daudé, qemu-block,
Stefan Hajnoczi
OSError can't be used like a tuple on Python 3, so change the
code to use `e.sterror` instead of `e[1]`.
Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/image-fuzzer/runner.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
index 95d84f38f3..1eb2138f94 100755
--- a/tests/image-fuzzer/runner.py
+++ b/tests/image-fuzzer/runner.py
@@ -159,7 +159,7 @@ class TestEnv(object):
os.makedirs(self.current_dir)
except OSError as e:
print("Error: The working directory '%s' cannot be used. Reason: %s"\
- % (self.work_dir, e[1]), file=sys.stderr)
+ % (self.work_dir, e.strerror), file=sys.stderr)
raise TestException
self.log = open(os.path.join(self.current_dir, "test.log"), "w")
self.parent_log = open(run_log, "a")
@@ -246,7 +246,7 @@ class TestEnv(object):
except OSError as e:
multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
% (test_summary, os.path.basename(current_cmd[0]),
- e[1]),
+ e.strerror),
sys.stderr, self.log, self.parent_log)
raise TestException
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript
2019-10-21 21:41 [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript Eduardo Habkost
@ 2019-10-23 15:41 ` John Snow
2019-11-05 15:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2019-10-23 15:41 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel
Cc: Philippe Mathieu-Daudé, qemu-block, Stefan Hajnoczi
On 10/21/19 5:41 PM, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
>
> Reported-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/image-fuzzer/runner.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
> index 95d84f38f3..1eb2138f94 100755
> --- a/tests/image-fuzzer/runner.py
> +++ b/tests/image-fuzzer/runner.py
> @@ -159,7 +159,7 @@ class TestEnv(object):
> os.makedirs(self.current_dir)
> except OSError as e:
> print("Error: The working directory '%s' cannot be used. Reason: %s"\
> - % (self.work_dir, e[1]), file=sys.stderr)
> + % (self.work_dir, e.strerror), file=sys.stderr)
> raise TestException
> self.log = open(os.path.join(self.current_dir, "test.log"), "w")
> self.parent_log = open(run_log, "a")
> @@ -246,7 +246,7 @@ class TestEnv(object):
> except OSError as e:
> multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
> % (test_summary, os.path.basename(current_cmd[0]),
> - e[1]),
> + e.strerror),
> sys.stderr, self.log, self.parent_log)
> raise TestException
>
>
--
—js
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript
2019-10-21 21:41 [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript Eduardo Habkost
2019-10-23 15:41 ` John Snow
@ 2019-11-05 15:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-11-05 15:36 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Stefan Hajnoczi, Philippe Mathieu-Daudé, qemu-devel,
qemu-block
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Mon, Oct 21, 2019 at 06:41:17PM -0300, Eduardo Habkost wrote:
> OSError can't be used like a tuple on Python 3, so change the
> code to use `e.sterror` instead of `e[1]`.
>
> Reported-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/image-fuzzer/runner.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-05 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-21 21:41 [PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript Eduardo Habkost
2019-10-23 15:41 ` John Snow
2019-11-05 15:36 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).