From: Sven Schnelle <svens@stackframe.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] net: add tulip (dec21143) driver
Date: Wed, 23 Oct 2019 10:06:09 +0200 [thread overview]
Message-ID: <20191023080608.GB19036@stackframe.org> (raw)
In-Reply-To: <CAFEAcA8DWwWLnMZqqsn4RpJbtPbxoPnrB2Z7UXvK3FhHRgk78A@mail.gmail.com>
On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote:
>
> There are a couple of minor wrong-indent nits:
>
> > +static void tulip_update_ts(TULIPState *s, int state)
> > +{
> > + s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT);
> > + s->csr[5] |= (state & CSR5_TS_MASK) << CSR5_TS_SHIFT;
> > + trace_tulip_tx_state(tulip_tx_state_name(state));
> > +}
>
> > +struct tulip_descriptor {
> > + uint32_t status;
> > + uint32_t control;
> > + uint32_t buf_addr1;
> > + uint32_t buf_addr2;
> > +};
>
> but maybe Jason can fix those up when he takes the patch ?
I'll send an updated version soon - there are some other small things
that i need to address.
Thanks
Sven
next prev parent reply other threads:[~2019-10-23 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 15:54 [PATCH v2] net: add tulip (dec21143) driver Sven Schnelle
2019-10-22 16:00 ` Peter Maydell
2019-10-23 8:06 ` Sven Schnelle [this message]
2019-10-23 7:26 ` no-reply
2019-10-25 11:43 ` Michael S. Tsirkin
2019-10-28 4:21 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023080608.GB19036@stackframe.org \
--to=svens@stackframe.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).