From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D040CA9EB6 for ; Wed, 23 Oct 2019 08:09:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6824C21906 for ; Wed, 23 Oct 2019 08:09:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=duncanthrax.net header.i=@duncanthrax.net header.b="iTJ8Iq0w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6824C21906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stackframe.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNBhp-0001Ge-CW for qemu-devel@archiver.kernel.org; Wed, 23 Oct 2019 04:09:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45858) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNBew-0007wx-7V for qemu-devel@nongnu.org; Wed, 23 Oct 2019 04:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNBep-0000wv-Vs for qemu-devel@nongnu.org; Wed, 23 Oct 2019 04:06:20 -0400 Received: from [2001:470:70c5:1111::170] (port=57428 helo=smtp.duncanthrax.net) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNBeo-0000uW-Fg for qemu-devel@nongnu.org; Wed, 23 Oct 2019 04:06:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date; bh=yvUWCn0OatQpyJTrQJOu1drZsZCj2Z91HHoJda77AN4=; b=iTJ8Iq0wsy+yiVjDO3caYKjCth kPij6IQ2sbAeTiwcPzf0UbWZpUcCrRXOTHjn2j8Pka33KBG7pD7dClYAUK75q9wiqi7vMundIzy1U DvtGvrgrM05v+28PKKxKj/cmMjzNpbox94RLhZ48mOgCj5jHK47F31snxdBnM7I4R4oU=; Received: from [2a01:4f8:121:41fa::170] (helo=stackframe.org) by smtp.eurescom.eu with esmtpa (Exim 4.86_2) (envelope-from ) id 1iNBej-0002Ea-6w; Wed, 23 Oct 2019 10:06:09 +0200 Date: Wed, 23 Oct 2019 10:06:09 +0200 From: Sven Schnelle To: Peter Maydell Subject: Re: [PATCH v2] net: add tulip (dec21143) driver Message-ID: <20191023080608.GB19036@stackframe.org> References: <20191022155413.4619-1-svens@stackframe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:70c5:1111::170 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , QEMU Developers , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote: > > There are a couple of minor wrong-indent nits: > > > +static void tulip_update_ts(TULIPState *s, int state) > > +{ > > + s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT); > > + s->csr[5] |= (state & CSR5_TS_MASK) << CSR5_TS_SHIFT; > > + trace_tulip_tx_state(tulip_tx_state_name(state)); > > +} > > > +struct tulip_descriptor { > > + uint32_t status; > > + uint32_t control; > > + uint32_t buf_addr1; > > + uint32_t buf_addr2; > > +}; > > but maybe Jason can fix those up when he takes the patch ? I'll send an updated version soon - there are some other small things that i need to address. Thanks Sven