* [PATCH] nvme: fix NSSRS offset in CAP register
@ 2019-10-23 7:33 Klaus Jensen
2019-10-23 15:26 ` John Snow
2019-10-29 14:12 ` Max Reitz
0 siblings, 2 replies; 4+ messages in thread
From: Klaus Jensen @ 2019-10-23 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Kevin Wolf, Javier Gonzalez, qemu-block, Max Reitz
Fix the offset of the NSSRS field the CAP register.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reported-by: Javier Gonzalez <javier.gonz@samsung.com>
---
include/block/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/block/nvme.h b/include/block/nvme.h
index 3ec8efcc435e..fa15b51c33bb 100644
--- a/include/block/nvme.h
+++ b/include/block/nvme.h
@@ -23,7 +23,7 @@ enum NvmeCapShift {
CAP_AMS_SHIFT = 17,
CAP_TO_SHIFT = 24,
CAP_DSTRD_SHIFT = 32,
- CAP_NSSRS_SHIFT = 33,
+ CAP_NSSRS_SHIFT = 36,
CAP_CSS_SHIFT = 37,
CAP_MPSMIN_SHIFT = 48,
CAP_MPSMAX_SHIFT = 52,
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nvme: fix NSSRS offset in CAP register
2019-10-23 7:33 [PATCH] nvme: fix NSSRS offset in CAP register Klaus Jensen
@ 2019-10-23 15:26 ` John Snow
2019-10-23 19:55 ` Klaus Birkelund
2019-10-29 14:12 ` Max Reitz
1 sibling, 1 reply; 4+ messages in thread
From: John Snow @ 2019-10-23 15:26 UTC (permalink / raw)
To: Klaus Jensen, qemu-devel; +Cc: Fam Zheng, Kevin Wolf, qemu-block, Max Reitz
On 10/23/19 3:33 AM, Klaus Jensen wrote:
> Fix the offset of the NSSRS field the CAP register.
From NVME 1.4, section 3 ("Controller Registers"), subsection 3.1.1
("Offset 0h: CAP – Controller Capabilities") CAP_NSSRS_SHIFT is bit 36,
not 33.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reported-by: Javier Gonzalez <javier.gonz@samsung.com>
> ---
> include/block/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/block/nvme.h b/include/block/nvme.h
> index 3ec8efcc435e..fa15b51c33bb 100644
> --- a/include/block/nvme.h
> +++ b/include/block/nvme.h
> @@ -23,7 +23,7 @@ enum NvmeCapShift {
> CAP_AMS_SHIFT = 17,
> CAP_TO_SHIFT = 24,
> CAP_DSTRD_SHIFT = 32,
> - CAP_NSSRS_SHIFT = 33,
> + CAP_NSSRS_SHIFT = 36,
> CAP_CSS_SHIFT = 37,
> CAP_MPSMIN_SHIFT = 48,
> CAP_MPSMAX_SHIFT = 52,
>
I like updating commit messages with spec references; if it can be
updated that would be nice.
Regardless:
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] nvme: fix NSSRS offset in CAP register
2019-10-23 15:26 ` John Snow
@ 2019-10-23 19:55 ` Klaus Birkelund
0 siblings, 0 replies; 4+ messages in thread
From: Klaus Birkelund @ 2019-10-23 19:55 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, Kevin Wolf, qemu-devel, qemu-block, Max Reitz
On Wed, Oct 23, 2019 at 11:26:57AM -0400, John Snow wrote:
>
>
> On 10/23/19 3:33 AM, Klaus Jensen wrote:
> > Fix the offset of the NSSRS field the CAP register.
>
> From NVME 1.4, section 3 ("Controller Registers"), subsection 3.1.1
> ("Offset 0h: CAP – Controller Capabilities") CAP_NSSRS_SHIFT is bit 36,
> not 33.
>
> >
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > Reported-by: Javier Gonzalez <javier.gonz@samsung.com>
> > ---
> > include/block/nvme.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/block/nvme.h b/include/block/nvme.h
> > index 3ec8efcc435e..fa15b51c33bb 100644
> > --- a/include/block/nvme.h
> > +++ b/include/block/nvme.h
> > @@ -23,7 +23,7 @@ enum NvmeCapShift {
> > CAP_AMS_SHIFT = 17,
> > CAP_TO_SHIFT = 24,
> > CAP_DSTRD_SHIFT = 32,
> > - CAP_NSSRS_SHIFT = 33,
> > + CAP_NSSRS_SHIFT = 36,
> > CAP_CSS_SHIFT = 37,
> > CAP_MPSMIN_SHIFT = 48,
> > CAP_MPSMAX_SHIFT = 52,
> >
>
> I like updating commit messages with spec references; if it can be
> updated that would be nice.
>
> Regardless:
>
> Reviewed-by: John Snow <jsnow@redhat.com>
>
Sounds good. Can the committer squash that in?
Cheers,
Klaus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: fix NSSRS offset in CAP register
2019-10-23 7:33 [PATCH] nvme: fix NSSRS offset in CAP register Klaus Jensen
2019-10-23 15:26 ` John Snow
@ 2019-10-29 14:12 ` Max Reitz
1 sibling, 0 replies; 4+ messages in thread
From: Max Reitz @ 2019-10-29 14:12 UTC (permalink / raw)
To: Klaus Jensen, qemu-devel
Cc: Fam Zheng, Kevin Wolf, Javier Gonzalez, qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]
On 23.10.19 09:33, Klaus Jensen wrote:
> Fix the offset of the NSSRS field the CAP register.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reported-by: Javier Gonzalez <javier.gonz@samsung.com>
> ---
> include/block/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks; added John’s note and applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-29 14:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 7:33 [PATCH] nvme: fix NSSRS offset in CAP register Klaus Jensen
2019-10-23 15:26 ` John Snow
2019-10-23 19:55 ` Klaus Birkelund
2019-10-29 14:12 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).