From: Jens Freimann <jfreimann@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
mst@redhat.com, aadam@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com, laine@redhat.com, ailan@redhat.com,
parav@mellanox.com
Subject: Re: [PATCH v5 02/11] pci: add option for net failover
Date: Wed, 23 Oct 2019 22:31:37 +0200 [thread overview]
Message-ID: <20191023203137.meh3edoudxulecys@jenstp.localdomain> (raw)
In-Reply-To: <20191023140211.4ada7ff3@x1.home>
On Wed, Oct 23, 2019 at 02:02:11PM -0600, Alex Williamson wrote:
>On Wed, 23 Oct 2019 21:30:35 +0200
>Jens Freimann <jfreimann@redhat.com> wrote:
>
>> On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote:
>> >On Wed, 23 Oct 2019 10:27:02 +0200
>> >Jens Freimann <jfreimann@redhat.com> wrote:
[...]
>> >Are there also multi-function considerations that
>> >should be prevented or documented? For example, if a user tries to
>> >configure both the primary and failover NICs in the same slot, I assume
>> >bad things will happen.
>>
>> I would have expected that this is already checked in pci code, but
>> it is not. I tried it and when I put both devices into the same slot
>> they are both unplugged from the guest during boot but nothing else
>> happens. I don't know what triggers that unplug of the devices.
>>
>> I'm not aware of any other problems regarding multi-function, which
>> doesn't mean there aren't any.
>
>Hmm, was the hidden device at function #0? The guest won't find any
>functions if function #0 isn't present, but I don't know what would
>trigger the hotplug. The angle I'm thinking is that we only have slot
>level granularity for hotplug, so any sort of automatic hotplug of a
>slot should probably think about bystander devices within the slot.
Yes that would be a problem, but isn't it the same in the non-failover case
where a user configures it wrong? The slot where the device is plugged is not
chosen automatically it's configured by the user, no? I might be mixing something
up here. I have no idea yet how to check if a slot is already populated, but
I'll think about it.
Thanks!
regards,
Jens
next prev parent reply other threads:[~2019-10-23 20:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:27 [PATCH v5 0/11] add failover feature for assigned network devices Jens Freimann
2019-10-23 8:27 ` [PATCH v5 01/11] qdev/qbus: add hidden device support Jens Freimann
2019-10-23 8:27 ` [PATCH v5 02/11] pci: add option for net failover Jens Freimann
2019-10-23 18:06 ` Alex Williamson
2019-10-23 19:30 ` Jens Freimann
2019-10-23 20:02 ` Alex Williamson
2019-10-23 20:31 ` Jens Freimann [this message]
2019-10-23 21:15 ` Alex Williamson
2019-10-24 17:57 ` Laine Stump
2019-10-25 10:52 ` Jens Freimann
2019-10-25 14:56 ` Alex Williamson
2019-10-24 5:03 ` Parav Pandit
2019-10-24 9:37 ` Jens Freimann
2019-10-24 16:34 ` Parav Pandit
2019-10-24 17:06 ` Alex Williamson
2019-10-24 16:52 ` Alex Williamson
2019-10-24 20:08 ` Jens Freimann
2019-10-24 17:22 ` Dr. David Alan Gilbert
2019-10-24 19:56 ` Jens Freimann
2019-10-23 8:27 ` [PATCH v5 03/11] pci: mark devices partially unplugged Jens Freimann
2019-10-23 8:27 ` [PATCH v5 04/11] pci: mark device having guest unplug request pending Jens Freimann
2019-10-23 8:27 ` [PATCH v5 05/11] qapi: add unplug primary event Jens Freimann
2019-10-23 11:32 ` Eric Blake
2019-10-23 8:27 ` [PATCH v5 06/11] qapi: add failover negotiated event Jens Freimann
2019-10-24 17:32 ` Dr. David Alan Gilbert
2019-10-24 20:03 ` Jens Freimann
2019-10-25 5:35 ` Markus Armbruster
2019-10-25 7:51 ` Jens Freimann
2019-10-23 8:27 ` [PATCH v5 07/11] migration: allow unplug during migration for failover devices Jens Freimann
2019-10-23 8:27 ` [PATCH v5 08/11] migration: add new migration state wait-unplug Jens Freimann
2019-10-23 8:27 ` [PATCH v5 09/11] libqos: tolerate wait-unplug migration state Jens Freimann
2019-10-23 8:27 ` [PATCH v5 10/11] net/virtio: add failover support Jens Freimann
2019-10-23 8:27 ` [PATCH v5 11/11] vfio: unplug failover primary device before migration Jens Freimann
2019-10-23 18:28 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023203137.meh3edoudxulecys@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=aadam@redhat.com \
--cc=ailan@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=laine@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).