From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <huth@tuxfamily.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-options: Rework the help text of the '-display' option
Date: Thu, 24 Oct 2019 10:23:51 +0200 [thread overview]
Message-ID: <20191024082351.n2j3ffimqlpbgqf3@sirius.home.kraxel.org> (raw)
In-Reply-To: <20191023120129.13721-1-huth@tuxfamily.org>
On Wed, Oct 23, 2019 at 02:01:28PM +0200, Thomas Huth wrote:
> Improve the help text of the "-display" option:
>
> - Only print the options that we have enabled in the binary
> (similar to what we do for other options like -netdev already)
>
> - The "frame=on|off" from "-display sdl" has been removed in commit
> 09bd7ba9f5f7 ("Remove deprecated -no-frame option"), so we should
> not show this in the help text anymore
>
> - The "-display egl-headless" line was missing a "\n" at the end
>
> - Indent the default display text in a nicer way
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
Queue up for UI.
thanks,
Gerd
prev parent reply other threads:[~2019-10-24 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 12:01 [PATCH] qemu-options: Rework the help text of the '-display' option Thomas Huth
2019-10-23 12:26 ` Philippe Mathieu-Daudé
2019-10-24 8:23 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024082351.n2j3ffimqlpbgqf3@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=huth@tuxfamily.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).