From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
qemu-block@nongnu.org, "Amit Shah" <amit@kernel.org>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fam Zheng" <fam@euphon.net>
Subject: [PATCH v6 3/9] virtio: Free rng and blk virqueues
Date: Thu, 24 Oct 2019 19:14:00 +0200 [thread overview]
Message-ID: <20191024171406.12504-4-eperezma@redhat.com> (raw)
In-Reply-To: <20191024171406.12504-1-eperezma@redhat.com>
The function virtio_del_queue was not called at these devices
unrealize() callbacks.
This was detected due to add an allocated element on the next commit
(used_elems) and running address sanitizer memory leak detector.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/block/virtio-blk.c | 5 +++++
hw/virtio/virtio-rng.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index ed2ddebd2b..ba846fe9dc 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1206,9 +1206,14 @@ static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp)
{
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VirtIOBlock *s = VIRTIO_BLK(dev);
+ VirtIOBlkConf *conf = &s->conf;
+ unsigned i;
virtio_blk_data_plane_destroy(s->dataplane);
s->dataplane = NULL;
+ for (i = 0; i < conf->num_queues; i++) {
+ virtio_del_queue(vdev, i);
+ }
qemu_del_vm_change_state_handler(s->change);
blockdev_mark_auto_del(s->blk);
virtio_cleanup(vdev);
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index e93bed020f..b498a20332 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -238,6 +238,7 @@ static void virtio_rng_device_unrealize(DeviceState *dev, Error **errp)
qemu_del_vm_change_state_handler(vrng->vmstate);
timer_del(vrng->rate_limit_timer);
timer_free(vrng->rate_limit_timer);
+ virtio_del_queue(vdev, 0);
virtio_cleanup(vdev);
}
--
2.16.5
next prev parent reply other threads:[~2019-10-24 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 17:13 [PATCH v6 0/9] Packed virtqueue for virtio Eugenio Pérez
2019-10-24 17:13 ` [PATCH v6 1/9] virtio: basic structure for packed ring Eugenio Pérez
2019-10-24 17:13 ` [PATCH v6 2/9] virtio: device/driver area size calculation refactor for split ring Eugenio Pérez
2019-10-24 17:14 ` Eugenio Pérez [this message]
2019-10-24 17:14 ` [PATCH v6 4/9] virtio: basic packed virtqueue support Eugenio Pérez
2019-10-24 17:14 ` [PATCH v6 5/9] virtio: event suppression support for packed ring Eugenio Pérez
2019-10-24 17:14 ` [PATCH v6 6/9] vhost_net: enable packed ring support Eugenio Pérez
2019-10-24 17:14 ` [PATCH v6 7/9] virtio: add property to enable packed virtqueue Eugenio Pérez
2019-10-24 17:14 ` [PATCH v6 8/9] virtio: add some rcu comments Eugenio Pérez
2019-10-24 17:14 ` [PATCH v6 9/9] virtio: Move vdev->broken check to dispatch drop_all Eugenio Pérez
2019-10-25 3:20 ` [PATCH v6 0/9] Packed virtqueue for virtio Jason Wang
2019-10-25 7:04 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024171406.12504-4-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=amit@kernel.org \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).