qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	qemu-block@nongnu.org, "Amit Shah" <amit@kernel.org>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Fam Zheng" <fam@euphon.net>,
	"Jens Freimann" <jfreimann@redhat.com>
Subject: [PATCH v7 4/8] virtio: Free rnd virqueue at unrealize()
Date: Fri, 25 Oct 2019 10:35:23 +0200	[thread overview]
Message-ID: <20191025083527.30803-5-eperezma@redhat.com> (raw)
In-Reply-To: <20191025083527.30803-1-eperezma@redhat.com>

The function virtio_del_queue was not called at unrealize() callback.

This was detected due to add an allocated element on the vq introduce
in future commits (used_elems) and running address sanitizer memory
leak detector.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 hw/virtio/virtio-rng.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index e93bed020f..b498a20332 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -238,6 +238,7 @@ static void virtio_rng_device_unrealize(DeviceState *dev, Error **errp)
     qemu_del_vm_change_state_handler(vrng->vmstate);
     timer_del(vrng->rate_limit_timer);
     timer_free(vrng->rate_limit_timer);
+    virtio_del_queue(vdev, 0);
     virtio_cleanup(vdev);
 }
 
-- 
2.16.5



  parent reply	other threads:[~2019-10-25  8:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  8:35 [PATCH v7 0/8] Packed virtqueue for virtio Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 1/8] virtio: basic structure for packed ring Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 2/8] virtio: device/driver area size calculation refactor for split ring Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 3/8] virtio: Free blk virqueues at unrealize() Eugenio Pérez
2019-10-25  8:35 ` Eugenio Pérez [this message]
2019-10-25  8:35 ` [PATCH v7 5/8] virtio: basic packed virtqueue support Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 6/8] virtio: event suppression support for packed ring Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 7/8] vhost_net: enable packed ring support Eugenio Pérez
2019-10-25  8:35 ` [PATCH v7 8/8] virtio: add property to enable packed virtqueue Eugenio Pérez
2019-10-25 11:34 ` [PATCH v7 0/8] Packed virtqueue for virtio Michael S. Tsirkin
2019-10-27  8:40   ` Stefan Hajnoczi
2019-10-28  8:04   ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025083527.30803-5-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=amit@kernel.org \
    --cc=fam@euphon.net \
    --cc=jasowang@redhat.com \
    --cc=jfreimann@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).