From: Luc Michel <luc.michel@greensocs.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Andrzej Zaborowski <balrogg@gmail.com>
Cc: Luc Michel <luc.michel@greensocs.com>
Subject: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state
Date: Fri, 1 Nov 2019 11:32:32 +0100 [thread overview]
Message-ID: <20191101103232.3692818-1-luc.michel@greensocs.com> (raw)
This machine modifies the CPU state when simulating suspend mode. This
commit adds a missing call to arm_rebuild_hflags after those
modifications.
Signed-off-by: Luc Michel <luc.michel@greensocs.com>
---
I came over this missing hflags rebuild while reviewing Edgar's similar
fix in hw/arm/boot.c. I could not find any other place where it would be
missing but I may be wrong.
---
hw/arm/pxa2xx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
index cdafde2f76..7982ffbfbe 100644
--- a/hw/arm/pxa2xx.c
+++ b/hw/arm/pxa2xx.c
@@ -306,6 +306,8 @@ static void pxa2xx_pwrmode_write(CPUARMState *env, const ARMCPRegInfo *ri,
cpu_physical_memory_write(8, &buffer, 4);
#endif
+ arm_rebuild_hflags(s->cpu->env);
+
/* Suspend */
cpu_interrupt(current_cpu, CPU_INTERRUPT_HALT);
--
2.23.0
next reply other threads:[~2019-11-01 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 10:32 Luc Michel [this message]
2019-11-01 10:42 ` [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state Peter Maydell
2019-11-01 10:54 ` Luc Michel
2019-11-05 11:20 ` Richard Henderson
2019-11-05 20:27 ` Peter Maydell
2019-11-01 12:01 ` no-reply
2019-11-01 12:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101103232.3692818-1-luc.michel@greensocs.com \
--to=luc.michel@greensocs.com \
--cc=balrogg@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).