qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	John Snow <jsnow@redhat.com>,
	qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [PULL 11/11] image-fuzzer: Use OSerror.strerror instead of tuple subscript
Date: Tue,  5 Nov 2019 16:43:32 +0100	[thread overview]
Message-ID: <20191105154332.181417-12-stefanha@redhat.com> (raw)
In-Reply-To: <20191105154332.181417-1-stefanha@redhat.com>

From: Eduardo Habkost <ehabkost@redhat.com>

OSError can't be used like a tuple on Python 3, so change the
code to use `e.sterror` instead of `e[1]`.

Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 20191021214117.18091-1-ehabkost@redhat.com
Message-Id: <20191021214117.18091-1-ehabkost@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/image-fuzzer/runner.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py
index 4ba5c79e13..2fc010fd9d 100755
--- a/tests/image-fuzzer/runner.py
+++ b/tests/image-fuzzer/runner.py
@@ -159,7 +159,7 @@ class TestEnv(object):
             os.makedirs(self.current_dir)
         except OSError as e:
             print("Error: The working directory '%s' cannot be used. Reason: %s"\
-                % (self.work_dir, e[1]), file=sys.stderr)
+                % (self.work_dir, e.strerror), file=sys.stderr)
             raise TestException
         self.log = open(os.path.join(self.current_dir, "test.log"), "w")
         self.parent_log = open(run_log, "a")
@@ -246,7 +246,7 @@ class TestEnv(object):
             except OSError as e:
                 multilog("%sError: Start of '%s' failed. Reason: %s\n\n"
                          % (test_summary, os.path.basename(current_cmd[0]),
-                            e[1]),
+                            e.strerror),
                          sys.stderr, self.log, self.parent_log)
                 raise TestException
 
-- 
2.23.0



  parent reply	other threads:[~2019-11-05 15:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 15:43 [PULL 00/11] Block patches Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 01/11] image-fuzzer: Open image files in binary mode Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 02/11] image-fuzzer: Write bytes instead of string to image file Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 03/11] image-fuzzer: Explicitly use integer division operator Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 04/11] image-fuzzer: Use io.StringIO Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__() Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 06/11] image-fuzzer: Return bytes objects on string fuzzing functions Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 07/11] image-fuzzer: Use bytes constant for field values Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 08/11] image-fuzzer: Encode file name and file format to bytes Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 09/11] image-fuzzer: Run using python3 Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 10/11] image-fuzzer: Use errors parameter of subprocess.Popen() Stefan Hajnoczi
2019-11-05 15:43 ` Stefan Hajnoczi [this message]
2019-11-06 16:01 ` [PULL 00/11] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105154332.181417-12-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).