From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 07/11] image-fuzzer: Use bytes constant for field values
Date: Tue, 5 Nov 2019 16:43:28 +0100 [thread overview]
Message-ID: <20191105154332.181417-8-stefanha@redhat.com> (raw)
In-Reply-To: <20191105154332.181417-1-stefanha@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
Field values are supposed to be bytes objects, not unicode
strings. Change two constants that were declared as strings.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20191016192430.25098-8-ehabkost@redhat.com
Message-Id: <20191016192430.25098-8-ehabkost@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/image-fuzzer/qcow2/layout.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
index 0adcbd448d..a0fd53c7ad 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -122,7 +122,7 @@ class Image(object):
def create_header(self, cluster_bits, backing_file_name=None):
"""Generate a random valid header."""
meta_header = [
- ['>4s', 0, "QFI\xfb", 'magic'],
+ ['>4s', 0, b"QFI\xfb", 'magic'],
['>I', 4, random.randint(2, 3), 'version'],
['>Q', 8, 0, 'backing_file_offset'],
['>I', 16, 0, 'backing_file_size'],
@@ -231,7 +231,7 @@ class Image(object):
feature_tables = []
feature_ids = []
inner_offset = self.ext_offset + ext_header_len
- feat_name = 'some cool feature'
+ feat_name = b'some cool feature'
while len(feature_tables) < num_fnt_entries * 3:
feat_type, feat_bit = gen_feat_ids()
# Remove duplicates
--
2.23.0
next prev parent reply other threads:[~2019-11-05 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 15:43 [PULL 00/11] Block patches Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 01/11] image-fuzzer: Open image files in binary mode Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 02/11] image-fuzzer: Write bytes instead of string to image file Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 03/11] image-fuzzer: Explicitly use integer division operator Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 04/11] image-fuzzer: Use io.StringIO Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 05/11] image-fuzzer: Use %r for all fiels at Field.__repr__() Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 06/11] image-fuzzer: Return bytes objects on string fuzzing functions Stefan Hajnoczi
2019-11-05 15:43 ` Stefan Hajnoczi [this message]
2019-11-05 15:43 ` [PULL 08/11] image-fuzzer: Encode file name and file format to bytes Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 09/11] image-fuzzer: Run using python3 Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 10/11] image-fuzzer: Use errors parameter of subprocess.Popen() Stefan Hajnoczi
2019-11-05 15:43 ` [PULL 11/11] image-fuzzer: Use OSerror.strerror instead of tuple subscript Stefan Hajnoczi
2019-11-06 16:01 ` [PULL 00/11] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105154332.181417-8-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).