From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Artyom Tarasenko" <atar4qemu@gmail.com>
Subject: [PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat
Date: Tue, 5 Nov 2019 19:11:09 +0100 [thread overview]
Message-ID: <20191105181119.26779-4-laurent@vivier.eu> (raw)
In-Reply-To: <20191105181119.26779-1-laurent@vivier.eu>
From: Richard Henderson <richard.henderson@linaro.org>
The error indicator for this syscall is -1, not 0.
Fixes: e374bfa35bfb ("shm tests - disabled clone test")
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191025113921.9412-3-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/tcg/multiarch/linux-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index fa4243fc0426..673d7c8a1c25 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -503,8 +503,9 @@ static void test_shm(void)
shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
ptr = shmat(shmid, NULL, 0);
- if (!ptr)
+ if (ptr == (void *)-1) {
error("shmat");
+ }
memset(ptr, 0, SHM_SIZE);
--
2.21.0
next prev parent reply other threads:[~2019-11-05 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 18:11 [PULL 00/13] Linux user for 4.2 patches Laurent Vivier
2019-11-05 18:11 ` [PULL 01/13] linux-user: Support for NETLINK socket options Laurent Vivier
2019-11-05 18:11 ` [PULL 02/13] scripts/qemu-binfmt-conf: Update for sparc64 Laurent Vivier
2019-11-05 18:11 ` Laurent Vivier [this message]
2019-11-05 18:11 ` [PULL 04/13] target/sparc: Define an enumeration for accessing env->regwptr Laurent Vivier
2019-11-05 18:11 ` [PULL 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h Laurent Vivier
2019-11-05 18:11 ` [PULL 06/13] linux-user/sparc: Begin using WREG constants in sparc/signal.c Laurent Vivier
2019-11-05 18:11 ` [PULL 07/13] linux-user/sparc: Use WREG_SP constant " Laurent Vivier
2019-11-05 18:11 ` [PULL 08/13] linux-user/sparc: Fix WREG usage in setup_frame Laurent Vivier
2019-11-05 18:11 ` [PULL 09/13] linux-user/sparc64: Fix target_signal_frame Laurent Vivier
2019-11-05 18:11 ` [PULL 10/13] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child Laurent Vivier
2019-11-05 18:11 ` [PULL 11/13] linux-user: Introduce cpu_clone_regs_parent Laurent Vivier
2019-11-05 18:11 ` [PULL 12/13] linux-user/sparc: Fix cpu_clone_regs_* Laurent Vivier
2019-11-05 18:11 ` [PULL 13/13] linux-user/alpha: Set r20 secondary return value Laurent Vivier
2019-11-05 22:06 ` [PULL 00/13] Linux user for 4.2 patches no-reply
2019-11-05 22:14 ` Laurent Vivier
2019-11-05 22:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105181119.26779-4-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).