From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com
Subject: [PATCH] s390x: Properly fetch and test the short psw on diag308 subc 0/1
Date: Tue, 5 Nov 2019 13:44:34 -0500 [thread overview]
Message-ID: <20191105184434.16148-1-frankja@linux.ibm.com> (raw)
We need to actually fetch the cpu mask and set it after checking for
psw bit 12 instead of completely ignoring it.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
target/s390x/cpu.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 736a7903e2..0acba843a7 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -76,8 +76,15 @@ static bool s390_cpu_has_work(CPUState *cs)
static void s390_cpu_load_normal(CPUState *s)
{
S390CPU *cpu = S390_CPU(s);
- cpu->env.psw.addr = ldl_phys(s->as, 4) & PSW_MASK_ESA_ADDR;
- cpu->env.psw.mask = PSW_MASK_32 | PSW_MASK_64;
+ uint64_t spsw = ldq_phys(s->as, 0);
+
+ /* Mask out bit 12 and instruction address */
+ cpu->env.psw.mask = spsw & 0xfff7ffff80000000UL;
+ cpu->env.psw.addr = spsw & 0x7fffffffUL;
+
+ if (!(spsw & 0x8000000000000UL)) {
+ s390_program_interrupt(&cpu->env, PGM_SPECIFICATION, 0, RA_IGNORED);
+ }
s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
}
#endif
--
2.20.1
next reply other threads:[~2019-11-05 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 18:44 Janosch Frank [this message]
2019-11-05 19:29 ` [PATCH] s390x: Properly fetch and test the short psw on diag308 subc 0/1 David Hildenbrand
2019-11-05 19:34 ` Janosch Frank
2019-11-05 20:07 ` David Hildenbrand
2019-11-11 13:52 ` Janosch Frank
2019-11-11 14:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105184434.16148-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).