From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96486C5DF62 for ; Wed, 6 Nov 2019 08:09:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F62F206A3 for ; Wed, 6 Nov 2019 08:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F62F206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSGNL-00088R-I0 for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 03:09:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38438) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSGMO-0007VE-0a for qemu-devel@nongnu.org; Wed, 06 Nov 2019 03:08:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSGMI-0007Iz-Eb for qemu-devel@nongnu.org; Wed, 06 Nov 2019 03:08:11 -0500 Received: from 14.mo3.mail-out.ovh.net ([188.165.43.98]:58340) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSGMI-0007D0-8h for qemu-devel@nongnu.org; Wed, 06 Nov 2019 03:08:06 -0500 Received: from player729.ha.ovh.net (unknown [10.108.35.119]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 0A6E42302B2 for ; Wed, 6 Nov 2019 09:07:56 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player729.ha.ovh.net (Postfix) with ESMTPSA id 77D99BF352FA; Wed, 6 Nov 2019 08:07:30 +0000 (UTC) Date: Wed, 6 Nov 2019 09:07:28 +0100 From: Greg Kurz To: Laurent Vivier Subject: Re: [PULL 0/4] Trivial branch patches Message-ID: <20191106090728.0f758e78@bahia.lan> In-Reply-To: <41caef0b-3db3-3fcf-a0b4-329e8e88ff0f@vivier.eu> References: <157296887817.27285.13935693519835086344@37313f22b938> <41caef0b-3db3-3fcf-a0b4-329e8e88ff0f@vivier.eu> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 9177210144560028120 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudduiedgudduiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjqdffgfeufgfipdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgsehtqhertdertdejnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucffohhmrghinhepphgrthgthhgvfidrohhrghenucfkpheptddrtddrtddrtddpkedvrddvheefrddvtdekrddvgeeknecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejvdelrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 188.165.43.98 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, sstabellini@kernel.org, berrange@redhat.com, ehabkost@redhat.com, paul@xen.org, qemu-trivial@nongnu.org, mjt@tls.msk.ru, claudio.fontana@huawei.com, qemu-devel@nongnu.org, chouteau@adacore.com, "Dr. David Alan Gilbert" , marcandre.lureau@redhat.com, frederic.konrad@adacore.com, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org, crosa@redhat.com, anthony.perard@citrix.com, pbonzini@redhat.com, david@gibson.dropbear.id.au, xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 Nov 2019 16:56:11 +0100 Laurent Vivier wrote: > Greg, Dave, >=20 > could you fix that? >=20 > Thanks, > Laurent >=20 > Le 05/11/2019 =C3=A0 16:48, no-reply@patchew.org a =C3=A9crit=C2=A0: > > Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vi= vier.eu/ > >=20 > >=20 > >=20 > > Hi, > >=20 > > This series seems to have some coding style problems. See output below = for > > more information: > >=20 > > Subject: [PULL 0/4] Trivial branch patches > > Type: series > > Message-id: 20191105144247.10301-1-laurent@vivier.eu > >=20 > > =3D=3D=3D TEST SCRIPT BEGIN =3D=3D=3D > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > =3D=3D=3D TEST SCRIPT END =3D=3D=3D > >=20 > > Switched to a new branch 'test' > > 85ac453 global: Squash 'the the' > > 9dd7da4 qom: Fix error message in object_class_property_add() > > 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses > > bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP regi= sters > >=20 > > =3D=3D=3D OUTPUT BEGIN =3D=3D=3D > > 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid cras= h when writing to PnP registers) > > 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit = accesses) > > 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_clas= s_property_add()) > > WARNING: line over 80 characters > > #31: FILE: qom/object.c:1109: > > + error_setg(errp, "attempt to add duplicate property '%s' to ob= ject (type '%s')", > >=20 > > WARNING: line over 80 characters > > #43: FILE: qom/object.c:1141: > > + error_setg(errp, "attempt to add duplicate property '%s' to cl= ass (type '%s')", > >=20 As mentioned in the changelog, this is deliberate. AFAIK better grep-ability has precedence over the 80 characters rule when it comes to error messages. Maybe we should teach checkpatch about that ? Cheers, -- Greg > > total: 0 errors, 2 warnings, 22 lines checked > >=20 > > Patch 3/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') > > ERROR: do not use C99 // comments > > #26: FILE: disas/libvixl/vixl/invalset.h:105: > > + // Note that this does not mean the backing storage is empty: it can= still > >=20 > > total: 1 errors, 0 warnings, 56 lines checked > >=20 > > Patch 4/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > >=20 > > =3D=3D=3D OUTPUT END =3D=3D=3D > >=20 > > Test command exited with code: 1 > >=20 > >=20 > > The full log is available at > > http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testin= g.checkpatch/?type=3Dmessage. > > --- > > Email generated automatically by Patchew [https://patchew.org/]. > > Please send your feedback to patchew-devel@redhat.com > >=20 >=20