From: Wei Yang <richardw.yang@linux.intel.com>
To: quintela@redhat.com, dgilbert@redhat.com
Cc: qemu-devel@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: [Patch v2 3/6] migration/postcopy: count target page number to decide the place_needed
Date: Thu, 7 Nov 2019 20:39:04 +0800 [thread overview]
Message-ID: <20191107123907.29791-4-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20191107123907.29791-1-richardw.yang@linux.intel.com>
In postcopy, it requires to place whole host page instead of target
page.
Currently, it relies on the page offset to decide whether this is the
last target page. We also can count the target page number during the
iteration. When the number of target page equals
(host page size / target page size), this means it is the last target
page in the host page.
This is a preparation for non-ordered target page transmission.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/ram.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index f59e3fe197..5c05376d8d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4017,6 +4017,7 @@ static int ram_load_postcopy(QEMUFile *f)
void *postcopy_host_page = mis->postcopy_tmp_page;
void *last_host = NULL;
bool all_zero = false;
+ int target_pages = 0;
while (!ret && !(flags & RAM_SAVE_FLAG_EOS)) {
ram_addr_t addr;
@@ -4051,6 +4052,7 @@ static int ram_load_postcopy(QEMUFile *f)
ret = -EINVAL;
break;
}
+ target_pages++;
matches_target_page_size = block->page_size == TARGET_PAGE_SIZE;
/*
* Postcopy requires that we place whole host pages atomically;
@@ -4082,8 +4084,10 @@ static int ram_load_postcopy(QEMUFile *f)
* If it's the last part of a host page then we place the host
* page
*/
- place_needed = (((uintptr_t)host + TARGET_PAGE_SIZE) &
- (block->page_size - 1)) == 0;
+ if (target_pages == (block->page_size / TARGET_PAGE_SIZE)) {
+ place_needed = true;
+ target_pages = 0;
+ }
place_source = postcopy_host_page;
}
last_host = host;
--
2.17.1
next prev parent reply other threads:[~2019-11-07 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 12:39 [Patch v2 0/6] migration/postcopy: enable compress during postcopy Wei Yang
2019-11-07 12:39 ` [Patch v2 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size Wei Yang
2020-01-09 9:39 ` Juan Quintela
2019-11-07 12:39 ` [Patch v2 2/6] migration/postcopy: wait for decompress thread in precopy Wei Yang
2020-01-09 9:40 ` Juan Quintela
2019-11-07 12:39 ` Wei Yang [this message]
2020-01-09 9:41 ` [Patch v2 3/6] migration/postcopy: count target page number to decide the place_needed Juan Quintela
2019-11-07 12:39 ` [Patch v2 4/6] migration/postcopy: set all_zero to true on the first target page Wei Yang
2020-01-09 9:41 ` Juan Quintela
2019-11-07 12:39 ` [Patch v2 5/6] migration/postcopy: enable random order target page arrival Wei Yang
2019-11-07 14:30 ` Dr. David Alan Gilbert
2019-11-08 0:40 ` Wei Yang
2020-01-09 9:42 ` Juan Quintela
2019-11-07 12:39 ` [Patch v2 6/6] migration/postcopy: enable compress during postcopy Wei Yang
2020-01-09 9:44 ` Juan Quintela
2019-12-16 2:35 ` [Patch v2 0/6] " Wei Yang
2019-12-18 19:55 ` Dr. David Alan Gilbert
2020-01-06 1:29 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107123907.29791-4-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).