From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: figlesia@xilinx.com, peter.maydell@linaro.org,
sstabellini@kernel.org, sai.pavan.boddu@xilinx.com,
frasse.iglesias@gmail.com, alistair@alistair23.me,
qemu-devel@nongnu.org, frederic.konrad@adacore.com,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
philmd@redhat.com, luc.michel@greensocs.com
Subject: Re: [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores
Date: Fri, 8 Nov 2019 13:36:54 +0100 [thread overview]
Message-ID: <20191108123654.GD2820@toto> (raw)
In-Reply-To: <3ee495ba-a88c-c81a-92e9-d5ad5d88022e@linaro.org>
On Thu, Nov 07, 2019 at 03:19:20PM +0100, Richard Henderson wrote:
> On 11/6/19 3:14 PM, Edgar E. Iglesias wrote:
> > @@ -967,12 +967,14 @@ static void dec_load(DisasContext *dc)
> > 10 -> 10
> > 11 -> 00 */
> > TCGv low = tcg_temp_new();
> > + TCGv t3 = tcg_const_tl(3);
> >
> > tcg_gen_andi_tl(low, addr, 3);
> > - tcg_gen_sub_tl(low, tcg_const_tl(3), low);
> > + tcg_gen_sub_tl(low, t3, low);
> > tcg_gen_andi_tl(addr, addr, ~3);
> > tcg_gen_or_tl(addr, addr, low);
> > tcg_temp_free(low);
> > + tcg_temp_free(t3);
> > break;
>
> While Luc correctly notes that tcg_gen_subfi_tl() may be used here, I will note
> (1) there's a typo in the comment (not 2->2, but 2->1), and (2) that this whole
> section can be done with
>
> tcg_gen_xori_tl(addr, addr, 3);
Nice!
I'll send out a new version shortly.
Best regards,
Edgar
>
> Similarly in dec_store.
>
> The other changes in this patch around gen_helper_memalign are ok.
>
>
> r~
next prev parent reply other threads:[~2019-11-08 12:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:14 [PATCH v1 0/3] target/microblaze: Plug tcg temp leaks Edgar E. Iglesias
2019-11-06 14:14 ` [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:37 ` Luc Michel
2019-11-06 21:55 ` Alistair Francis
2019-11-07 14:19 ` Richard Henderson
2019-11-08 12:36 ` Edgar E. Iglesias [this message]
2019-11-06 14:14 ` [PATCH v1 2/3] target/microblaze: Plug temp leaks with delay slot setup Edgar E. Iglesias
2019-11-06 14:33 ` Philippe Mathieu-Daudé
2019-11-06 14:41 ` Luc Michel
2019-11-06 21:56 ` Alistair Francis
2019-11-07 14:21 ` Richard Henderson
2019-11-06 14:14 ` [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp() Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:42 ` Luc Michel
2019-11-06 21:57 ` Alistair Francis
2019-11-07 14:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108123654.GD2820@toto \
--to=edgar.iglesias@xilinx.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).