From: Palmer Dabbelt <palmer@dabbelt.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-riscv@nongnu.org
Subject: [PATCH v2 0/3] device_tree: Allow for and use string arrays [Was: RISC-V: virt: This is a "sifive, test1" test finisher]
Date: Fri, 8 Nov 2019 11:47:55 -0800 [thread overview]
Message-ID: <20191108194758.17813-1-palmer@dabbelt.com> (raw)
Device trees commonly contain arrays of strings for compatible nodes.
We recently extended the "sifive,test0" node in a backwards-compatible
way, but QEMU didn't contain an FDT function to set 'compatible =
"sifive,test1", "sifive,test0";'. I've converted over the code from the
ARM virt board that was doing something similar to be a helper function,
which I could then use for RISC-V as well.
I haven't tested the ARM change, but I have tested the RISC-V one. It
appears to parse correctly in Linux, and a DTC treats it the same way as
it treats the string arrays it compiles -- specifically:
$ cat test.dts
/dts-v1/;
/ {
string = "stringa";
strings = "string1", "string2";
};
$ dtc -I dts test.dts -O dtb -o test.dtb
$ dtc -I dtb test.dtb -O dts -o out.dts
$ cat out.dts
/dts-v1/;
/ {
string = "stringa";
strings = "string1\0string2";
};
and
$ qemu-system-riscv64 -m virt,dumpdtb=out.dtb ...
$ dtc -I dtb test.dtb -O dts -o out.dts
$ cat out.dts
...
test@100000 {
reg = <0x00 0x100000 0x00 0x1000>;
compatible = "sifive,test1\0sifive,test0";
};
...
Changes since v1 <20191107222500.8018-1-palmer@sifive.com>:
* This is now a multiple patch series.
* The hepler function has been added and used by the RISC-V virt board.
* The ARM virt board has been converted to use the helper function
next reply other threads:[~2019-11-08 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 19:47 Palmer Dabbelt [this message]
2019-11-08 19:47 ` [PATCH v2 1/3] device_tree: Add a helper function for string arrays Palmer Dabbelt
2019-11-09 15:59 ` Peter Maydell
2019-11-10 19:44 ` David Gibson
2019-11-08 19:47 ` [PATCH v2 2/3] ARM/virt: Use fdt_setprop_strings() Palmer Dabbelt
2019-11-09 15:56 ` Peter Maydell
2019-11-10 19:47 ` David Gibson
2019-11-08 19:47 ` [PATCH v2 3/3] RISC-V: virt: This is a "sifive,test1" test finisher Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108194758.17813-1-palmer@dabbelt.com \
--to=palmer@dabbelt.com \
--cc=Alistair.Francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).