From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B590CC43331 for ; Mon, 11 Nov 2019 16:29:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C95220656 for ; Mon, 11 Nov 2019 16:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItW71+v4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C95220656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUCZd-0005Zt-SU for qemu-devel@archiver.kernel.org; Mon, 11 Nov 2019 11:29:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUCA0-0000Hy-6N for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:03:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUC9y-00036s-TN for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:03:23 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:29558 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUC9y-00035f-Ou for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:03:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573488202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmeBo3JNakPin2YEux2IhikmCE6WDGLfwJ+Y7vlA4eU=; b=ItW71+v4frPU1ARaD9mGS38etWBVc57kl0DBpVG7ThzVFKpVrsWwsl6MyajmetoGKWTclZ 5C8hWI2jVnFBJc9O2gaIPMnwXYI1318m2xt0nY1Cnd8w0MWS+lXLHtmt3AKCIfav+R1oXs anXiExn2S6Scg9pWr0by4JFAvS/v4H0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-qOoY9_l9PMuY3GXE_myZFA-1; Mon, 11 Nov 2019 11:03:19 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D764A1852E23; Mon, 11 Nov 2019 16:03:17 +0000 (UTC) Received: from localhost (ovpn-117-116.ams2.redhat.com [10.36.117.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 728175D9C9; Mon, 11 Nov 2019 16:03:17 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041 Date: Mon, 11 Nov 2019 17:02:12 +0100 Message-Id: <20191111160216.197086-20-mreitz@redhat.com> In-Reply-To: <20191111160216.197086-1-mreitz@redhat.com> References: <20191111160216.197086-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: qOoY9_l9PMuY3GXE_myZFA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 2ab59e9c53..d636cb7f1d 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -918,8 +918,7 @@ class TestRepairQuorum(iotests.QMPTestCase): =20 self.complete_and_wait(drive=3D"job0") self.assert_has_block_node("repair0", quorum_repair_img) - # TODO: a better test requiring some QEMU infrastructure will be a= dded - # to check that this file is really driven by quorum + self.vm.assert_block_path('quorum0', '/children.1', 'repair0') self.vm.shutdown() self.assertTrue(iotests.compare_images(quorum_img2, quorum_repair_= img), 'target image does not match source after mirrorin= g') @@ -1041,9 +1040,7 @@ class TestRepairQuorum(iotests.QMPTestCase): =20 self.complete_and_wait('job0') self.assert_has_block_node("repair0", quorum_repair_img) - # TODO: a better test requiring some QEMU infrastructure will be a= dded - # to check that this file is really driven by quorum - self.vm.shutdown() + self.vm.assert_block_path('quorum0', '/children.1', 'repair0') =20 # Test mirroring with a source that does not have any parents (not even a # BlockBackend) --=20 2.23.0