From: Greg Kurz <groug@kaod.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
Date: Tue, 12 Nov 2019 09:53:21 +0100 [thread overview]
Message-ID: <20191112095321.0b42ade4@bahia.lan> (raw)
In-Reply-To: <20191112034532.69079-1-aik@ozlabs.ru>
On Tue, 12 Nov 2019 14:45:32 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> Recent git versions support worktrees where .git is not a directory but
> a file with a path to the .git repository; however the get_maintainer.pl
> script only recognises the .git directory, let's fix it.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
Makes sense. The script in the linux kernel tree has this since 2014 BTW :)
Reviewed-by: Greg Kurz <groug@kaod.org>
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 71415e3c7061..27991eb1cfb4 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -81,7 +81,7 @@ my %VCS_cmds;
>
> my %VCS_cmds_git = (
> "execute_cmd" => \&git_execute_cmd,
> - "available" => '(which("git") ne "") && (-d ".git")',
> + "available" => '(which("git") ne "") && (-e ".git")',
> "find_signers_cmd" =>
> "git log --no-color --follow --since=\$email_git_since " .
> '--format="GitCommit: %H%n' .
next prev parent reply other threads:[~2019-11-12 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
2019-11-12 8:50 ` Stefano Garzarella
2019-11-12 8:53 ` Greg Kurz [this message]
2019-11-12 9:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112095321.0b42ade4@bahia.lan \
--to=groug@kaod.org \
--cc=aik@ozlabs.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).