From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46270C43331 for ; Tue, 12 Nov 2019 08:54:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19334204FD for ; Tue, 12 Nov 2019 08:54:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19334204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iURwd-0005HZ-Av for qemu-devel@archiver.kernel.org; Tue, 12 Nov 2019 03:54:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iURvf-0004Zm-EF for qemu-devel@nongnu.org; Tue, 12 Nov 2019 03:53:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iURve-0003qo-59 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 03:53:39 -0500 Received: from 10.mo179.mail-out.ovh.net ([46.105.79.46]:54378) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iURvd-0003cP-VG for qemu-devel@nongnu.org; Tue, 12 Nov 2019 03:53:38 -0500 Received: from player735.ha.ovh.net (unknown [10.109.143.201]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 07A0214ACD1 for ; Tue, 12 Nov 2019 09:53:28 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player735.ha.ovh.net (Postfix) with ESMTPSA id 7BAC8BFDC3C1; Tue, 12 Nov 2019 08:53:23 +0000 (UTC) Date: Tue, 12 Nov 2019 09:53:21 +0100 From: Greg Kurz To: Alexey Kardashevskiy Subject: Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Message-ID: <20191112095321.0b42ade4@bahia.lan> In-Reply-To: <20191112034532.69079-1-aik@ozlabs.ru> References: <20191112034532.69079-1-aik@ozlabs.ru> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 8288875114856290805 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedruddvkedgjedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthejredtredtvdenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeefhedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.79.46 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 12 Nov 2019 14:45:32 +1100 Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: Alexey Kardashevskiy > --- Makes sense. The script in the linux kernel tree has this since 2014 BTW :) Reviewed-by: Greg Kurz > scripts/get_maintainer.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 71415e3c7061..27991eb1cfb4 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -81,7 +81,7 @@ my %VCS_cmds; > > my %VCS_cmds_git = ( > "execute_cmd" => \&git_execute_cmd, > - "available" => '(which("git") ne "") && (-d ".git")', > + "available" => '(which("git") ne "") && (-e ".git")', > "find_signers_cmd" => > "git log --no-color --follow --since=\$email_git_since " . > '--format="GitCommit: %H%n' .