From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD0DC432C3 for ; Wed, 13 Nov 2019 16:31:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9742A23142 for ; Wed, 13 Nov 2019 15:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G9b9iDJH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9742A23142 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUuwU-0005zQ-RH for qemu-devel@archiver.kernel.org; Wed, 13 Nov 2019 10:52:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38406) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUuvo-0005RD-WE for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:51:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUuvn-0003hC-U2 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:51:44 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:23751 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUuvn-0003gi-Q1 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:51:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573660303; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GyEFUBbfBFMaMCu1EBAiIK1jkFlYlvPn+Eim+xNKIng=; b=G9b9iDJHWhKGb1tPeMfbnMtU3AxH79sAMoWSAAeMBT2VHiyrl/10nlduZ3pxyGV6MtZixv dykZBzOyVnAaQvsBDRgAr0xBWAbLzpU6/slXX/LxlxhXqXqPWxYVUn72gExgQwo/NV3JTc AnNVrgDHIy7THEnzU+UGqJ1a6iUlCpU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-tCEcYiMYOQyGTl_JLgb4bA-1; Wed, 13 Nov 2019 10:51:40 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 810B5800C77; Wed, 13 Nov 2019 15:51:38 +0000 (UTC) Received: from redhat.com (unknown [10.42.16.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46CBD66095; Wed, 13 Nov 2019 15:51:27 +0000 (UTC) Date: Wed, 13 Nov 2019 15:51:25 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jag Raman Subject: Re: [RFC v4 PATCH 02/49] multi-process: util: Add qemu_thread_cancel() to cancel running thread Message-ID: <20191113155125.GI2445240@redhat.com> References: <20191113153006.GA563983@stefanha-x1.localdomain> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: tCEcYiMYOQyGTl_JLgb4bA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: elena.ufimtseva@oracle.com, fam@euphon.net, thuth@redhat.com, ross.lagerwall@citrix.com, ehabkost@redhat.com, john.g.johnson@oracle.com, mst@redhat.com, konrad.wilk@oracle.com, qemu-devel@nongnu.org, armbru@redhat.com, quintela@redhat.com, liran.alon@oracle.com, kraxel@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com, kwolf@redhat.com, marcandre.lureau@gmail.com, mreitz@redhat.com, kanth.ghatraju@oracle.com, dgilbert@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 13, 2019 at 10:38:06AM -0500, Jag Raman wrote: >=20 >=20 > On 11/13/2019 10:30 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:08:43AM -0400, Jagannathan Raman wrote: > > > qemu_thread_cancel() added to destroy a given running thread. > > > This will be needed in the following patches. > > >=20 > > > Signed-off-by: John G Johnson > > > Signed-off-by: Jagannathan Raman > > > Signed-off-by: Elena Ufimtseva > > > --- > > > include/qemu/thread.h | 1 + > > > util/qemu-thread-posix.c | 10 ++++++++++ > > > 2 files changed, 11 insertions(+) > >=20 > > Is this still needed? I thought previous discussion concluded that > > thread cancellation is hard to get right and it's not actually used by > > this series? >=20 > Hi Stefan, >=20 > This is used in PATCH 41/49. I don't believe the cancellation usage in that patch is safe :-) Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|