qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Cédric Le Goater" <clg@kaod.org>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PATCH v3 3/4] watchdog/aspeed: Improve watchdog timeout message
Date: Thu, 14 Nov 2019 08:43:00 +1030	[thread overview]
Message-ID: <20191113221301.8768-4-joel@jms.id.au> (raw)
In-Reply-To: <20191113221301.8768-1-joel@jms.id.au>

Users benefit from knowing which watchdog timer has expired. The address
of the watchdog's registers unambiguously indicates which has expired,
so log that.

Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2: Use HWADDR_PRIx
v3: Fix spacing
---
 hw/watchdog/wdt_aspeed.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
index 145be6f99ce2..d283d07d6546 100644
--- a/hw/watchdog/wdt_aspeed.c
+++ b/hw/watchdog/wdt_aspeed.c
@@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev)
         return;
     }
 
-    qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n");
+    qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %" HWADDR_PRIx " expired.\n",
+                  s->iomem.addr);
     watchdog_perform_action();
     timer_del(s->timer);
 }
-- 
2.24.0



  parent reply	other threads:[~2019-11-13 22:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 22:12 [PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes Joel Stanley
2019-11-13 22:12 ` [PATCH v3 1/4] aspeed/sdmc: Make ast2600 default 1G Joel Stanley
2019-11-13 22:12 ` [PATCH v3 2/4] aspeed/scu: Fix W1C behavior Joel Stanley
2019-11-13 22:13 ` Joel Stanley [this message]
2019-11-13 22:13 ` [PATCH v3 4/4] watchdog/aspeed: Fix AST2600 frequency behaviour Joel Stanley
2019-11-14 14:04 ` [PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes Peter Maydell
2019-11-14 14:16   ` Cédric Le Goater
2019-11-19 13:44     ` Peter Maydell
2019-11-19 14:05       ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113221301.8768-4-joel@jms.id.au \
    --to=joel@jms.id.au \
    --cc=alex.bennee@linaro.org \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).