From: Christoph Hellwig <hch@infradead.org>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Anton Nefedov <anton.nefedov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-stable@nongnu.org,
qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Denis V . Lunev" <den@openvz.org>
Subject: Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize
Date: Thu, 14 Nov 2019 08:27:51 -0800 [thread overview]
Message-ID: <20191114162751.GA29976@infradead.org> (raw)
In-Reply-To: <20191101152510.11719-4-mreitz@redhat.com>
On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote:
> The XFS kernel driver has a bug that may cause data corruption for qcow2
> images as of qemu commit c8bb23cbdbe32f. We can work around it by
> treating post-EOF fallocates as serializing up until infinity (INT64_MAX
> in practice).
This has been fixed in the kernel a while ago. I don't think it makes
sense to work around it in qemu.
next prev parent reply other threads:[~2019-11-14 16:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 15:25 [PATCH for-4.2 v2 0/3] qcow2: Fix data corruption on XFS Max Reitz
2019-11-01 15:25 ` [PATCH for-4.2 v2 1/3] block: Make wait/mark serialising requests public Max Reitz
2019-11-01 15:25 ` [PATCH for-4.2 v2 2/3] block: Add bdrv_co_get_self_request() Max Reitz
2019-11-01 15:25 ` [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize Max Reitz
2019-11-14 16:27 ` Christoph Hellwig [this message]
2019-11-14 17:15 ` Max Reitz
2019-11-14 17:16 ` Max Reitz
2020-06-02 14:43 ` Vladimir Sementsov-Ogievskiy
2020-06-02 15:46 ` Max Reitz
2020-06-02 16:16 ` Vladimir Sementsov-Ogievskiy
2020-06-02 16:38 ` Max Reitz
2020-06-02 17:01 ` Vladimir Sementsov-Ogievskiy
2020-06-02 17:08 ` Vladimir Sementsov-Ogievskiy
2020-08-22 17:03 ` Vladimir Sementsov-Ogievskiy
2020-08-22 17:04 ` Vladimir Sementsov-Ogievskiy
2020-08-26 8:23 ` Vladimir Sementsov-Ogievskiy
2020-08-26 11:20 ` Vladimir Sementsov-Ogievskiy
2019-11-01 15:48 ` [PATCH for-4.2 v2 0/3] qcow2: Fix data corruption on XFS no-reply
2019-11-04 8:29 ` Max Reitz
2019-11-04 9:09 ` Max Reitz
2019-11-04 9:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114162751.GA29976@infradead.org \
--to=hch@infradead.org \
--cc=anton.nefedov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).