From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip pointer
Date: Fri, 15 Nov 2019 13:45:52 +0100 [thread overview]
Message-ID: <20191115134552.4c40155c@bahia.lan> (raw)
In-Reply-To: <35f82bf2-3557-2d0c-5915-7f2b4b977fbe@kaod.org>
On Fri, 15 Nov 2019 13:24:50 +0100
Cédric Le Goater <clg@kaod.org> wrote:
> > diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> > index 55eee95104da..fce6d8d9b31b 100644
> > --- a/include/hw/ppc/pnv_core.h
> > +++ b/include/hw/ppc/pnv_core.h
> > @@ -36,11 +36,11 @@ typedef struct PnvChip PnvChip;
> > typedef struct PnvCore {
> > /*< private >*/
> > CPUCore parent_obj;
> > + PnvChip *chip;
> >
> > /*< public >*/
> > PowerPCCPU **threads;
> > uint32_t pir;
> > - PnvChip *chip;
> >
> > MemoryRegion xscom_regs;
> > } PnvCore;
> >
>
>
> Why this change ?
>
Because PnvCore::chip is an PnvCore internal that shouldn't be
used outside pnv_core.c IMHO.
> C.
next prev parent reply other threads:[~2019-11-15 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 11:53 [PATCH for-5.0 0/8] ppc: Consolidate QOM links and pointers to the same object Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 1/8] xive: Link "cpu" property to XiveTCTX::cs pointer Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 2/8] xive: Link "xive" property to XiveSource::xive pointer Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 3/8] xive: Link "xive" property to XiveEndSource::xrtr pointer Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 4/8] ppc/pnv: Link "psi" property to PnvLpc::psi pointer Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 5/8] ppc/pnv: Link "psi" property to PnvOCC::psi pointer Greg Kurz
2019-11-15 11:53 ` [PATCH for-5.0 6/8] ppc/pnv: Link "chip" property to PnvHomer::chip pointer Greg Kurz
2019-11-15 11:54 ` [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip pointer Greg Kurz
2019-11-15 12:24 ` Cédric Le Goater
2019-11-15 12:45 ` Greg Kurz [this message]
2019-11-15 11:54 ` [PATCH for-5.0 8/8] ppc/pnv: Link "chip" property to PnvXive::chip pointer Greg Kurz
2019-11-15 12:25 ` Cédric Le Goater
2019-11-15 12:46 ` Greg Kurz
2019-11-15 12:16 ` [PATCH for-5.0 0/8] ppc: Consolidate QOM links and pointers to the same object Cédric Le Goater
2019-11-15 13:28 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115134552.4c40155c@bahia.lan \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).