From: Robert Foley <robert.foley@linaro.org>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, alex.bennee@linaro.org,
robert.foley@linaro.org, peter.puhov@linaro.org
Subject: [PATCH v3 1/6] Fix double free issue in qemu_set_log_filename().
Date: Mon, 18 Nov 2019 16:15:23 -0500 [thread overview]
Message-ID: <20191118211528.3221-2-robert.foley@linaro.org> (raw)
In-Reply-To: <20191118211528.3221-1-robert.foley@linaro.org>
After freeing the logfilename, we set logfilename to NULL, in case of an
error which returns without setting logfilename.
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
v2
- moved this change to the beginning of the patch series.
---
v1
- This is new in the patch v1.
---
util/log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/log.c b/util/log.c
index 1ca13059ee..4316fe74ee 100644
--- a/util/log.c
+++ b/util/log.c
@@ -113,6 +113,7 @@ void qemu_set_log_filename(const char *filename, Error **errp)
{
char *pidstr;
g_free(logfilename);
+ logfilename = NULL;
pidstr = strstr(filename, "%");
if (pidstr) {
--
2.17.1
next prev parent reply other threads:[~2019-11-18 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 21:15 [PATCH v3 0/6] Make the qemu_logfile handle thread safe Robert Foley
2019-11-18 21:15 ` Robert Foley [this message]
2019-11-18 21:15 ` [PATCH v3 2/6] Cleaned up flow of code in qemu_set_log(), to simplify and clarify Robert Foley
2019-11-18 21:15 ` [PATCH v3 3/6] Add a mutex to guarantee single writer to qemu_logfile handle Robert Foley
2019-11-18 21:15 ` [PATCH v3 4/6] qemu_log_lock/unlock now preserves the " Robert Foley
2019-11-18 21:15 ` [PATCH v3 5/6] Add use of RCU for qemu_logfile Robert Foley
2019-11-18 21:15 ` [PATCH v3 6/6] Added tests for close and change of logfile Robert Foley
2019-11-20 16:33 ` [PATCH v3 0/6] Make the qemu_logfile handle thread safe Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118211528.3221-2-robert.foley@linaro.org \
--to=robert.foley@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.puhov@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).