qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Fam Zheng" <fam@euphon.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional
Date: Wed, 20 Nov 2019 10:57:57 +0000	[thread overview]
Message-ID: <20191120105801.2735-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20191120105801.2735-1-alex.bennee@linaro.org>

While the concept of only dropping to ssh if a test fails is nice it
is more useful for this to be unconditional. You usually just want to
get the build up and running and then noodle around debugging or
attempting to replicate.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 91a9226026d..0b8c1b26576 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -403,7 +403,7 @@ def main(vmcls):
     exitcode = 0
     if vm.ssh(*cmd) != 0:
         exitcode = 3
-    if exitcode != 0 and args.interactive:
+    if args.interactive:
         vm.ssh()
 
     if not args.snapshot:
-- 
2.20.1



  reply	other threads:[~2019-11-20 11:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 10:57 [PULL for rc3 0/5] a few doc and testing tweaks Alex Bennée
2019-11-20 10:57 ` Alex Bennée [this message]
2019-11-20 10:57 ` [PULL 2/5] docs/devel: rename plugins.rst to tcg-plugins.rst Alex Bennée
2019-11-20 10:57 ` [PULL 3/5] docs/devel: update tcg-plugins.rst with API versioning details Alex Bennée
2019-11-20 10:58 ` [PULL 4/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS Alex Bennée
2019-11-20 10:58 ` [PULL 5/5] tests/tcg: modify multiarch tests to work with clang Alex Bennée
2019-11-21 12:45 ` [PULL for rc3 0/5] a few doc and testing tweaks Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120105801.2735-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).