qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Juan Quintela <quintela@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Cole Robinson <crobinso@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used
Date: Thu, 21 Nov 2019 20:48:33 +1100	[thread overview]
Message-ID: <20191121094833.GT5582@umbus.fritz.box> (raw)
In-Reply-To: <87v9rdmy1o.fsf@trasno.org>

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

On Thu, Nov 21, 2019 at 09:30:27AM +0100, Juan Quintela wrote:
> Laurent Vivier <lvivier@redhat.com> wrote:
> > On 21/11/2019 08:18, Juan Quintela wrote:
> >> Laurent Vivier <lvivier@redhat.com> wrote:
> >>> On ppc64, migration-test only works with kvm_hv, and we already
> >>> have a check to verify the module is loaded.
> >>>
> >>> kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists,
> >>> but on some systems (like build systems) /dev/kvm can be missing
> >>> (by administrators choice).
> >>>
> >>> And as kvm_hv exists test-migration is started but QEMU falls back to
> >>> TCG because it cannot be used:
> >>>
> >>>     Could not access KVM kernel module: No such file or directory
> >>>     failed to initialize KVM: No such file or directory
> >>>     Back to tcg accelerator
> >>>
> >>> And as the test is done with TCG, it fails.
> >>>
> >>> As for s390x, we must check for the existence and the access rights
> >>> of /dev/kvm.
> >>>
> >>> Reported-by: Cole Robinson <crobinso@redhat.com>
> >>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> >> 
> >> Reviewed-by: Juan Quintela <quintela@redhat.com>
> >> 
> >> Oh, why it is so difficult!!!
> >> 
> >> Thanks, Juan.
> >> 
> >
> > David,
> >
> > could you add this one too to your ppc-for-4.2 queue?
> 
> I was about to ask if you preffered it to go through the migration tree.
> 
> David?

Migration tree is good for me.

> 
> Later, Juan.
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-11-21 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 17:09 [PATCH] pseries: disable migration-test if /dev/kvm cannot be used Laurent Vivier
2019-11-20 17:40 ` Thomas Huth
2019-11-20 18:33 ` Greg Kurz
2019-11-21  7:18 ` Juan Quintela
2019-11-21  8:08   ` Laurent Vivier
2019-11-21  8:30     ` Juan Quintela
2019-11-21  9:48       ` David Gibson [this message]
2019-11-26 17:49       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191121094833.GT5582@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=crobinso@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).