From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] kvm: Reallocate dirty_bmap when we change a slot
Date: Thu, 21 Nov 2019 12:17:35 -0500 [thread overview]
Message-ID: <20191121171735.GE26741@xz-x1> (raw)
In-Reply-To: <20191121165645.33483-1-dgilbert@redhat.com>
On Thu, Nov 21, 2019 at 04:56:45PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> kvm_set_phys_mem can be called to reallocate a slot by something the
> guest does (e.g. writing to PAM and other chipset registers).
> This can happen in the middle of a migration, and if we're unlucky
> it can now happen between the split 'sync' and 'clear'; the clear
> asserts if there's no bmap to clear. Recreate the bmap whenever
> we change the slot, keeping the clear path happy.
>
> Typically this is triggered by the guest rebooting during a migrate.
>
> Corresponds to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1772774
> https://bugzilla.redhat.com/show_bug.cgi?id=1771032
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks!
--
Peter Xu
prev parent reply other threads:[~2019-11-21 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 16:56 [PATCH] kvm: Reallocate dirty_bmap when we change a slot Dr. David Alan Gilbert (git)
2019-11-21 17:17 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121171735.GE26741@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).