qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, pmorel@linux.ibm.com, david@redhat.com,
	cohuck@redhat.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
	mihajlov@linux.ibm.com
Subject: [PATCH v3 1/5] s390x: Don't do a normal reset on the initial cpu
Date: Mon, 25 Nov 2019 04:03:44 -0500	[thread overview]
Message-ID: <20191125090348.27010-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20191125090348.27010-1-frankja@linux.ibm.com>

The initiating cpu needs to be reset with an initial reset. While
doing a normal reset followed by a initial reset is not wrong per se,
the Ultravisor will only allow the correct reset to be performed.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index d3edeef0ad..c1d1440272 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -348,6 +348,9 @@ static void s390_machine_reset(MachineState *machine)
         break;
     case S390_RESET_LOAD_NORMAL:
         CPU_FOREACH(t) {
+            if (t == cs) {
+                continue;
+            }
             run_on_cpu(t, s390_do_cpu_reset, RUN_ON_CPU_NULL);
         }
         subsystem_reset();
-- 
2.20.1



  reply	other threads:[~2019-11-25  9:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  9:03 [PATCH v3 0/5] s390x: Reset cleanup Janosch Frank
2019-11-25  9:03 ` Janosch Frank [this message]
2019-11-25 13:11   ` [PATCH v3 1/5] s390x: Don't do a normal reset on the initial cpu Cornelia Huck
2019-11-25  9:03 ` [PATCH v3 2/5] s390x: Move reset normal to shared reset handler Janosch Frank
2019-11-25 13:19   ` Cornelia Huck
2019-11-27 17:45     ` David Hildenbrand
2019-11-25  9:03 ` [PATCH v3 3/5] s390x: Move initial reset Janosch Frank
2019-11-25  9:03 ` [PATCH v3 4/5] s390x: Move clear reset Janosch Frank
2019-11-25 13:37   ` Cornelia Huck
2019-11-25 13:49     ` Janosch Frank
2019-11-25 15:42       ` Cornelia Huck
2019-11-25  9:03 ` [PATCH v3 5/5] s390x: Beautify diag308 handling Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125090348.27010-2-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=mihajlov@linux.ibm.com \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).