* [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue
@ 2019-11-25 12:34 pannengyuan
2019-11-25 23:13 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: pannengyuan @ 2019-11-25 12:34 UTC (permalink / raw)
To: david; +Cc: kuhn.chenqun, qemu-arm, PanNengyuan, qemu-devel, kenny.zhangjun
From: PanNengyuan <pannengyuan@huawei.com>
This fixes coverity issues 68911917:
360
CID 68911917: (NULL_RETURNS)
361. dereference: Dereferencing "source", which is known to be
"NULL".
361 if (source->mask & event_mask) {
362 break;
363 }
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: PanNengyuan <pannengyuan@huawei.com>
---
hw/ppc/spapr_events.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index 0e4c195..e355e00 100644
--- a/hw/ppc/spapr_events.c
+++ b/hw/ppc/spapr_events.c
@@ -358,6 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
rtas_event_log_to_source(spapr,
spapr_event_log_entry_type(entry));
+ g_assert(source);
if (source->mask & event_mask) {
break;
}
--
2.7.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue
2019-11-25 12:34 [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue pannengyuan
@ 2019-11-25 23:13 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-11-25 23:13 UTC (permalink / raw)
To: pannengyuan; +Cc: kuhn.chenqun, qemu-arm, qemu-devel, kenny.zhangjun
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
On Mon, Nov 25, 2019 at 08:34:51PM +0800, pannengyuan@huawei.com wrote:
> From: PanNengyuan <pannengyuan@huawei.com>
>
> This fixes coverity issues 68911917:
> 360
> CID 68911917: (NULL_RETURNS)
> 361. dereference: Dereferencing "source", which is known to be
> "NULL".
> 361 if (source->mask & event_mask) {
> 362 break;
> 363 }
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: PanNengyuan <pannengyuan@huawei.com>
Applied to ppc-for-4.2, thanks.
> ---
> hw/ppc/spapr_events.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
> index 0e4c195..e355e00 100644
> --- a/hw/ppc/spapr_events.c
> +++ b/hw/ppc/spapr_events.c
> @@ -358,6 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
> rtas_event_log_to_source(spapr,
> spapr_event_log_entry_type(entry));
>
> + g_assert(source);
> if (source->mask & event_mask) {
> break;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-25 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-25 12:34 [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue pannengyuan
2019-11-25 23:13 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).