From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: lvivier@redhat.com, PanNengyuan <pannengyuan@huawei.com>,
qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org,
clg@kaod.org, Euler Robot <euler.robot@huawei.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PULL 8/8] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue
Date: Tue, 26 Nov 2019 17:01:51 +1100 [thread overview]
Message-ID: <20191126060151.729845-9-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20191126060151.729845-1-david@gibson.dropbear.id.au>
From: PanNengyuan <pannengyuan@huawei.com>
This fixes coverity issues 68911917:
360
CID 68911917: (NULL_RETURNS)
361. dereference: Dereferencing "source", which is known to be
"NULL".
361 if (source->mask & event_mask) {
362 break;
363 }
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: PanNengyuan <pannengyuan@huawei.com>
Message-Id: <1574685291-38176-1-git-send-email-pannengyuan@huawei.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr_events.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index 0e4c19523a..e355e000d0 100644
--- a/hw/ppc/spapr_events.c
+++ b/hw/ppc/spapr_events.c
@@ -358,6 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
rtas_event_log_to_source(spapr,
spapr_event_log_entry_type(entry));
+ g_assert(source);
if (source->mask & event_mask) {
break;
}
--
2.23.0
next prev parent reply other threads:[~2019-11-26 6:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 6:01 [PULL 0/8] ppc-for-4.2 queue 20191126 David Gibson
2019-11-26 6:01 ` [PULL 1/8] pseries: fix migration-test and pxe-test David Gibson
2019-11-26 6:01 ` [PULL 2/8] kvm: Introduce KVM irqchip change notifier David Gibson
2019-11-26 6:01 ` [PULL 3/8] vfio/pci: Split vfio_intx_update() David Gibson
2019-11-26 6:01 ` [PULL 4/8] vfio/pci: Respond to KVM irqchip change notifier David Gibson
2019-12-30 13:23 ` Eduardo Habkost
2019-11-26 6:01 ` [PULL 5/8] spapr: Handle irq backend changes with VFIO PCI devices David Gibson
2019-11-26 6:01 ` [PULL 6/8] spapr: Work around spurious warnings from vfio INTx initialization David Gibson
2019-11-26 6:01 ` [PULL 7/8] mos6522: update counters when timer interrupts are off David Gibson
2019-11-26 6:01 ` David Gibson [this message]
2019-11-26 17:28 ` [PULL 0/8] ppc-for-4.2 queue 20191126 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126060151.729845-9-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=euler.robot@huawei.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).