From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 671B8C432C0 for ; Wed, 27 Nov 2019 22:39:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36E65206E0 for ; Wed, 27 Nov 2019 22:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36E65206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5xn-00055W-ED for qemu-devel@archiver.kernel.org; Wed, 27 Nov 2019 17:39:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49444) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5wV-00048n-Kx for qemu-devel@nongnu.org; Wed, 27 Nov 2019 17:37:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia5wU-0007Lw-AT for qemu-devel@nongnu.org; Wed, 27 Nov 2019 17:37:51 -0500 Received: from 6.mo69.mail-out.ovh.net ([46.105.50.107]:53900) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ia5wS-0007H6-Lz for qemu-devel@nongnu.org; Wed, 27 Nov 2019 17:37:49 -0500 Received: from player788.ha.ovh.net (unknown [10.108.16.204]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id A4029733D9 for ; Wed, 27 Nov 2019 23:37:45 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player788.ha.ovh.net (Postfix) with ESMTPSA id 059CAC98C649; Wed, 27 Nov 2019 22:37:43 +0000 (UTC) Date: Wed, 27 Nov 2019 23:37:42 +0100 From: Greg Kurz To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v6] 9pfs: well form error hint helpers Message-ID: <20191127233742.198e00f7@bahia.w3ibm.bluemix.net> In-Reply-To: <20191127191549.21216-1-vsementsov@virtuozzo.com> References: <20191127191549.21216-1-vsementsov@virtuozzo.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 18066471382031898963 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeihedgudeivdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjqdffgfeufgfipdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgsehtjeertdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeekkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.50.107 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 27 Nov 2019 22:15:49 +0300 Vladimir Sementsov-Ogievskiy wrote: > Make error_append_security_model_hint and > error_append_socket_sockfd_hint hint append helpers well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Acked-by: Greg Kurz > --- > > v6: add Greg's a-b > I've already pushed that to my 9p-next branch: https://github.com/gkurz/qemu/commits/9p-next > hw/9pfs/9p-local.c | 4 ++-- > hw/9pfs/9p-proxy.c | 5 +++-- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index 4708c0bd89..76fa1858b7 100644 > --- a/hw/9pfs/9p-local.c > +++ b/hw/9pfs/9p-local.c > @@ -1473,9 +1473,9 @@ static void local_cleanup(FsContext *ctx) > g_free(data); > } > > -static void error_append_security_model_hint(Error **errp) > +static void error_append_security_model_hint(Error **errp_in) > { > - error_append_hint(errp, "Valid options are: security_model=" > + error_append_hint(errp_in, "Valid options are: security_model=" > "[passthrough|mapped-xattr|mapped-file|none]\n"); > } > > diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c > index 97ab9c58a5..9e29abc3ef 100644 > --- a/hw/9pfs/9p-proxy.c > +++ b/hw/9pfs/9p-proxy.c > @@ -1114,9 +1114,10 @@ static int connect_namedsocket(const char *path, Error **errp) > return sockfd; > } > > -static void error_append_socket_sockfd_hint(Error **errp) > +static void error_append_socket_sockfd_hint(Error **errp_in) > { > - error_append_hint(errp, "Either specify socket=/some/path where /some/path" > + error_append_hint(errp_in, > + "Either specify socket=/some/path where /some/path" > " points to a listening AF_UNIX socket or sock_fd=fd" > " where fd is a file descriptor to a connected AF_UNIX" > " socket\n");