From: Halil Pasic <pasic@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled
Date: Fri, 29 Nov 2019 14:51:36 +0100 [thread overview]
Message-ID: <20191129145136.6edeb41c.pasic@linux.ibm.com> (raw)
In-Reply-To: <20191128120223-mutt-send-email-mst@kernel.org>
On Thu, 28 Nov 2019 12:03:01 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
[..]
> >
> > But it keeps nagging me, is it really OK for the device to access the
> > virtio ring during reset? My intuition tells me that the device should
> > not look for new requests after it has been told to reset.
>
>
> Well it's after it was told to reset but it's not after
> it completed reset. So I think it's fine ...
Thanks Michael! I agree and we are covered by the specification. Namely
3.3.1 Driver Requirements: Device Cleanup says "Thus a driver MUST
ensure a virtqueue isn’t live (by device reset) before removing exposed
buffers.". Draining the available buffers from the queue is not wrong --
although possibly unnecessary.
So I guess for externally initiated resets (ones not initiated by the
driver) we just have to make sure that the virtio structures are intact
until the virtio device is reset.
Regards,
Halil
[..]
next prev parent reply other threads:[~2019-11-29 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:50 [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled Michael Roth
2019-11-20 6:12 ` no-reply
2019-11-20 16:23 ` Michael Roth
2019-11-20 16:40 ` Dr. David Alan Gilbert
2019-11-28 16:48 ` Halil Pasic
2019-11-28 17:03 ` Michael S. Tsirkin
2019-11-29 13:51 ` Halil Pasic [this message]
2019-12-05 6:04 ` Alexey Kardashevskiy
2019-12-11 16:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129145136.6edeb41c.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).