From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34DBC432C0 for ; Tue, 3 Dec 2019 02:48:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C26D020684 for ; Tue, 3 Dec 2019 02:48:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PQrgbuw6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C26D020684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibyF2-00081T-IM for qemu-devel@archiver.kernel.org; Mon, 02 Dec 2019 21:48:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32781) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibxxI-0003M6-SD for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibxxB-0008SV-8G for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:21 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:46435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibxxA-0008I9-Np for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:16 -0500 Received: by mail-pg1-x544.google.com with SMTP id z124so851076pgb.13 for ; Mon, 02 Dec 2019 18:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Yw6liUOnTrdCiX1bj2V8EHNGM2nemLD+p3/vAl9e62o=; b=PQrgbuw6OQKZbq9XNotG18JWkKYmvYeFzME4EbDrrbPaNcX3DEbB1R+vBZJ9YF0Yko 29+xR7O8uRjBzhNMjwWd3vCnkOLpiggI7ZIAO/UO0RSWwW9c9QTr0+qSFbqREEampCjL Ks1AoQ6zqmOWsEQK90/MljU6c+mPAHYTogYBOxBHQ6GkpUj53kguQ414KPzN8N9luL7x jXATIfwqwECM1OsqqfL9XnTbWJktJ6AOPGJzh7D4EbzKqVFZsiiPkORAa+QDF6RObsbQ Z2S9nWnpbefgoZFGw/WhLNKykomLJ/eE6L3VFz7aS+VX+cmnsM1TmCWnkb1W9/Y2+xbS IN+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Yw6liUOnTrdCiX1bj2V8EHNGM2nemLD+p3/vAl9e62o=; b=fXVcVPyuCOL7B6Bm+70oc8IMewEv292vFZy9TfPo/Th1brRzozehUerxS+Km7mZEor iAfWonK8/Z9ed3elzoo8jaYQsXYwBrv4JXXEbYGSytt1uzitM/XLQmZuZmGwtOlH0rex IbfuemT9rkaqDPTAFPEOA6Xe9q943zjJrccxVmkhT5DipPz4nVhHAr6PqA0kJRkXeUmH N8E2Mjgrs7UQI08PXsBhoHm9yOHCbbwPcGPzYuFt+b6h6fWA4EXxQaNiPHpsxf4S2bMS u8PGeEPsnGIGA0pjyi7xggzyz39g+ETk/2aF0NT0lppq4cs6qtmO/t11AmUbnPK1mz6Q n1Jw== X-Gm-Message-State: APjAAAV9DEPi2GwlqF7e2XsJhlO/+mAZUvUiqb6G7nM4eXqPEWKcV9Su QN0m0Hp1357pgzZHhWxzx+rJAjKTy0o= X-Google-Smtp-Source: APXvYqxYc1QvRA+b1Ge6RQYbSQCW7JWzGjz4+Jzwy1VlKXBuqeawnOkwJGzuY7++qAVidz97Qv6i+A== X-Received: by 2002:a63:93:: with SMTP id 141mr2758722pga.411.1575340207863; Mon, 02 Dec 2019 18:30:07 -0800 (PST) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id q22sm873695pfg.170.2019.12.02.18.30.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 18:30:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 22/40] target/arm: Update aa64_zva_access for EL2 Date: Mon, 2 Dec 2019 18:29:19 -0800 Message-Id: <20191203022937.1474-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191203022937.1474-1-richard.henderson@linaro.org> References: <20191203022937.1474-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The comment that we don't support EL2 is somewhat out of date. Update to include checks against HCR_EL2.TDZ. Signed-off-by: Richard Henderson --- target/arm/helper.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 4f5e0b656c..ffa82b5509 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -4109,11 +4109,27 @@ static void tlbi_aa64_ipas2e1is_write(CPUARMState *env, const ARMCPRegInfo *ri, static CPAccessResult aa64_zva_access(CPUARMState *env, const ARMCPRegInfo *ri, bool isread) { - /* We don't implement EL2, so the only control on DC ZVA is the - * bit in the SCTLR which can prohibit access for EL0. - */ - if (arm_current_el(env) == 0 && !(env->cp15.sctlr_el[1] & SCTLR_DZE)) { - return CP_ACCESS_TRAP; + int cur_el = arm_current_el(env); + + if (cur_el < 2) { + uint64_t hcr = arm_hcr_el2_eff(env); + + if (cur_el == 0) { + if ((hcr & (HCR_E2H | HCR_TGE)) == (HCR_E2H | HCR_TGE)) { + if (!(env->cp15.sctlr_el[2] & SCTLR_DZE)) { + return CP_ACCESS_TRAP_EL2; + } + } else { + if (!(env->cp15.sctlr_el[1] & SCTLR_DZE)) { + return CP_ACCESS_TRAP; + } + if (hcr & HCR_TDZ) { + return CP_ACCESS_TRAP_EL2; + } + } + } else if (hcr & HCR_TDZ) { + return CP_ACCESS_TRAP_EL2; + } } return CP_ACCESS_OK; } -- 2.17.1