qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PATCH  v2 3/6] linux-user: add target_mmap_complete tracepoint
Date: Thu,  5 Dec 2019 12:25:14 +0000	[thread overview]
Message-ID: <20191205122518.10010-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20191205122518.10010-1-alex.bennee@linaro.org>

For full details we also want to see where the mmaps end up.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/mmap.c       | 2 +-
 linux-user/trace-events | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index f4f10deaeac..0b1b43ac3c0 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -538,8 +538,8 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
  the_end1:
     page_set_flags(start, start + len, prot | PAGE_VALID);
  the_end:
+    trace_target_mmap_complete(start);
 #ifdef DEBUG_MMAP
-    printf("ret=0x" TARGET_ABI_FMT_lx "\n", start);
     page_dump(stdout);
     printf("\n");
 #endif
diff --git a/linux-user/trace-events b/linux-user/trace-events
index 8d8d4c3c68c..6d6aeef7b52 100644
--- a/linux-user/trace-events
+++ b/linux-user/trace-events
@@ -15,3 +15,4 @@ user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_add
 # mmap.c
 target_mprotect(uint64_t start, uint64_t len, int flags) "start=0x%"PRIx64 " len=0x%"PRIx64 " prot=0x%x"
 target_mmap(uint64_t start, uint64_t len, int pflags, int mflags, int fd, uint64_t offset) "start=0x%"PRIx64 " len=0x%"PRIx64 " prot=0x%x flags=0x%x fd=%d offset=0x%"PRIx64
+target_mmap_complete(uint64_t retaddr) "retaddr=0x%"PRIx64
-- 
2.20.1



  parent reply	other threads:[~2019-12-05 14:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 12:25 [PATCH v2 0/6] linux-user mmap debug cleanup Alex Bennée
2019-12-05 12:25 ` [PATCH v2 1/6] linux-user: convert target_mprotect debug to tracepoint Alex Bennée
2019-12-05 15:43   ` Richard Henderson
2019-12-11 14:46   ` Laurent Vivier
2019-12-05 12:25 ` [PATCH v2 2/6] linux-user: convert target_mmap " Alex Bennée
2019-12-05 15:44   ` Richard Henderson
2019-12-11 14:48   ` Laurent Vivier
2019-12-05 12:25 ` Alex Bennée [this message]
2019-12-11 14:48   ` [PATCH v2 3/6] linux-user: add target_mmap_complete tracepoint Laurent Vivier
2019-12-05 12:25 ` [PATCH v2 4/6] linux-user: log page table changes under -d page Alex Bennée
2019-12-05 15:45   ` Richard Henderson
2019-12-11 14:53   ` Laurent Vivier
2019-12-05 12:25 ` [PATCH v2 5/6] linux-user: convert target_munmap debug to a tracepoint Alex Bennée
2019-12-11 14:54   ` Laurent Vivier
2019-12-16 12:00     ` Alex Bennée
2019-12-16 12:05       ` Laurent Vivier
2019-12-18 20:03         ` Alex Bennée
2019-12-05 12:25 ` [PATCH v2 6/6] trace: replace hand-crafted pattern_glob with g_pattern_match_simple Alex Bennée
2019-12-05 15:51   ` Richard Henderson
2019-12-06 11:03   ` Stefan Hajnoczi
2019-12-06 11:59     ` Alex Bennée
2019-12-09 15:58   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205122518.10010-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).