From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7C8C43603 for ; Thu, 5 Dec 2019 15:50:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2E10206DB for ; Thu, 5 Dec 2019 15:50:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2E10206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ictP0-0005Na-3e for qemu-devel@archiver.kernel.org; Thu, 05 Dec 2019 10:50:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49712) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icswg-0000Y9-SO for qemu-devel@nongnu.org; Thu, 05 Dec 2019 10:21:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icswe-0006j5-TG for qemu-devel@nongnu.org; Thu, 05 Dec 2019 10:21:34 -0500 Received: from relay.sw.ru ([185.231.240.75]:43676) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icswd-0005lz-1D; Thu, 05 Dec 2019 10:21:32 -0500 Received: from vovaso.qa.sw.ru ([10.94.3.0] helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1icsvZ-00007O-1t; Thu, 05 Dec 2019 18:20:25 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v7 00/21] error: prepare for auto propagated local_err Date: Thu, 5 Dec 2019 18:19:58 +0300 Message-Id: <20191205152019.8454-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , "Michael S. Tsirkin" , Jason Wang , Michael Roth , Gerd Hoffmann , qemu-block@nongnu.org, David Hildenbrand , armbru@redhat.com, Halil Pasic , Christian Borntraeger , "Gonglei \(Arei\)" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Tony Krowiak , Eduardo Habkost , Greg Kurz , "Dr. David Alan Gilbert" , Alex Williamson , David Gibson , Kevin Wolf , vsementsov@virtuozzo.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Pierre Morel , Cornelia Huck , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi all! This is the first part of the bit series, which contains mostly simple cleanups. v6 was sent in separate (I'm sorry for inconvenience) v7: by Markus review (and with his prepared fixups, thanks a lot!): - don't rename Error** paramters - switch to Error *const * where appropriate last patch is new and replaces "nbd: well form nbd_iter_channel_error errp handler" Vladimir Sementsov-Ogievskiy (21): hw/core/loader-fit: fix freeing errp in fit_load_fdt net/net: Clean up variable shadowing in net_client_init() error: rename errp to errp_in where it is IN-argument hmp: drop Error pointer indirection in hmp_handle_error vnc: drop Error pointer indirection in vnc_client_io_error qdev-monitor: well form error hint helpers ppc: well form kvmppc_hint_smt_possible error hint helper 9pfs: well form error hint helpers hw/core/qdev: cleanup Error ** variables block/snapshot: rename Error ** parameter to more common errp hw/i386/amd_iommu: rename Error ** parameter to more common errp qga: rename Error ** parameter to more common errp monitor/qmp-cmds: rename Error ** parameter to more common errp hw/s390x: rename Error ** parameter to more common errp hw/sd: drop extra whitespace in sdhci_sysbus_realize() header hw/tpm: rename Error ** parameter to more common errp hw/usb: rename Error ** parameter to more common errp include/qom/object.h: rename Error ** parameter to more common errp backends/cryptodev: drop local_err from cryptodev_backend_complete() hw/vfio/ap: drop local_err from vfio_ap_realize nbd: assert that Error** is not NULL in nbd_iter_channel_error Cc: "Gonglei (Arei)" Cc: Eric Blake Cc: Kevin Wolf Cc: Max Reitz Cc: "Marc-André Lureau" Cc: Greg Kurz Cc: Paul Burton Cc: Aleksandar Rikalo Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: Richard Henderson Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: David Gibson Cc: Cornelia Huck Cc: David Hildenbrand Cc: Halil Pasic Cc: Christian Borntraeger Cc: "Philippe Mathieu-Daudé" Cc: Stefan Berger Cc: Gerd Hoffmann Cc: Tony Krowiak Cc: Pierre Morel Cc: Alex Williamson Cc: Markus Armbruster Cc: Michael Roth Cc: "Dr. David Alan Gilbert" Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Cc: qemu-ppc@nongnu.org Cc: qemu-s390x@nongnu.org include/block/snapshot.h | 2 +- include/monitor/hmp.h | 2 +- include/qapi/error.h | 6 +- include/qom/object.h | 4 +- target/ppc/kvm_ppc.h | 4 +- ui/vnc.h | 2 +- backends/cryptodev.c | 11 +-- block/nbd.c | 1 + block/snapshot.c | 4 +- dump/dump-hmp-cmds.c | 4 +- hw/9pfs/9p-local.c | 2 +- hw/9pfs/9p-proxy.c | 2 +- hw/core/loader-fit.c | 5 +- hw/core/machine-hmp-cmds.c | 6 +- hw/core/qdev.c | 28 ++++--- hw/i386/amd_iommu.c | 14 ++-- hw/ppc/spapr.c | 2 +- hw/s390x/event-facility.c | 2 +- hw/s390x/s390-stattrib.c | 3 +- hw/sd/sdhci.c | 2 +- hw/tpm/tpm_emulator.c | 8 +- hw/usb/dev-network.c | 2 +- hw/vfio/ap.c | 9 +-- monitor/hmp-cmds.c | 155 ++++++++++++++++++------------------- monitor/qmp-cmds.c | 2 +- net/net.c | 17 ++-- qdev-monitor.c | 16 ++-- qga/commands-posix.c | 2 +- qga/commands-win32.c | 2 +- qga/commands.c | 12 +-- qom/qom-hmp-cmds.c | 4 +- target/ppc/kvm.c | 2 +- ui/vnc.c | 20 ++--- util/error.c | 6 +- 34 files changed, 173 insertions(+), 190 deletions(-) -- 2.21.0