* [PATCH] qapi: better document NVMe blockdev @device parameter
@ 2019-12-06 14:38 Daniel P. Berrangé
2019-12-06 14:43 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2019-12-06 14:38 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P. Berrangé, Stefan Hajnoczi, Markus Armbruster,
qemu-block
Mention that this is a PCI device address & give the format it is
expected it. Also mention that it must be first unbound from any
host kernel driver.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
qapi/block-core.json | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..fcb52ec24f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2963,9 +2963,13 @@
#
# Driver specific block device options for the NVMe backend.
#
-# @device: controller address of the NVMe device.
+# @device: PCI controller address of the NVMe device in
+# format hhhh:bb:ss.f (host:bus:slot.function)
# @namespace: namespace number of the device, starting from 1.
#
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
# Since: 2.12
##
{ 'struct': 'BlockdevOptionsNVMe',
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] qapi: better document NVMe blockdev @device parameter
2019-12-06 14:38 [PATCH] qapi: better document NVMe blockdev @device parameter Daniel P. Berrangé
@ 2019-12-06 14:43 ` Stefan Hajnoczi
2019-12-06 14:51 ` Eric Blake
2019-12-10 14:51 ` Kevin Wolf
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2019-12-06 14:43 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, qemu-block, Markus Armbruster
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Fri, Dec 06, 2019 at 02:38:11PM +0000, Daniel P. Berrangé wrote:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any
> host kernel driver.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> qapi/block-core.json | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: better document NVMe blockdev @device parameter
2019-12-06 14:38 [PATCH] qapi: better document NVMe blockdev @device parameter Daniel P. Berrangé
2019-12-06 14:43 ` Stefan Hajnoczi
@ 2019-12-06 14:51 ` Eric Blake
2019-12-06 14:53 ` Daniel P. Berrangé
2019-12-10 14:51 ` Kevin Wolf
2 siblings, 1 reply; 5+ messages in thread
From: Eric Blake @ 2019-12-06 14:51 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Stefan Hajnoczi, Markus Armbruster, qemu-block, qemu-stable
On 12/6/19 8:38 AM, Daniel P. Berrangé wrote:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any
maybe s/expected it/expecting/
> host kernel driver.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> qapi/block-core.json | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0cf68fea14..fcb52ec24f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2963,9 +2963,13 @@
> #
> # Driver specific block device options for the NVMe backend.
> #
> -# @device: controller address of the NVMe device.
> +# @device: PCI controller address of the NVMe device in
> +# format hhhh:bb:ss.f (host:bus:slot.function)
> # @namespace: namespace number of the device, starting from 1.
> #
> +# Note that the PCI @device must have been unbound from any host
> +# kernel driver before instructing QEMU to add the blockdev.
> +#
Reviewed-by: Eric Blake <eblake@redhat.com>
Doesn't affect code, but similarly no reason to hurry this into 4.2.
5.0 and qemu-stable (cc'd) is good enough.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: better document NVMe blockdev @device parameter
2019-12-06 14:51 ` Eric Blake
@ 2019-12-06 14:53 ` Daniel P. Berrangé
0 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2019-12-06 14:53 UTC (permalink / raw)
To: Eric Blake
Cc: qemu-stable, Stefan Hajnoczi, qemu-devel, qemu-block,
Markus Armbruster
On Fri, Dec 06, 2019 at 08:51:15AM -0600, Eric Blake wrote:
> On 12/6/19 8:38 AM, Daniel P. Berrangé wrote:
> > Mention that this is a PCI device address & give the format it is
> > expected it. Also mention that it must be first unbound from any
>
> maybe s/expected it/expecting/
It was supposed to be "in" rather than "it", but your suggestion
is fine too.
>
> > host kernel driver.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > qapi/block-core.json | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 0cf68fea14..fcb52ec24f 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2963,9 +2963,13 @@
> > #
> > # Driver specific block device options for the NVMe backend.
> > #
> > -# @device: controller address of the NVMe device.
> > +# @device: PCI controller address of the NVMe device in
> > +# format hhhh:bb:ss.f (host:bus:slot.function)
> > # @namespace: namespace number of the device, starting from 1.
> > #
> > +# Note that the PCI @device must have been unbound from any host
> > +# kernel driver before instructing QEMU to add the blockdev.
> > +#
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Doesn't affect code, but similarly no reason to hurry this into 4.2. 5.0 and
> qemu-stable (cc'd) is good enough.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: better document NVMe blockdev @device parameter
2019-12-06 14:38 [PATCH] qapi: better document NVMe blockdev @device parameter Daniel P. Berrangé
2019-12-06 14:43 ` Stefan Hajnoczi
2019-12-06 14:51 ` Eric Blake
@ 2019-12-10 14:51 ` Kevin Wolf
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2019-12-10 14:51 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: qemu-block, qemu-devel, Stefan Hajnoczi, Markus Armbruster
Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any
> host kernel driver.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-10 14:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-06 14:38 [PATCH] qapi: better document NVMe blockdev @device parameter Daniel P. Berrangé
2019-12-06 14:43 ` Stefan Hajnoczi
2019-12-06 14:51 ` Eric Blake
2019-12-06 14:53 ` Daniel P. Berrangé
2019-12-10 14:51 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).