From: Cleber Rosa <crosa@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Beraldo Leal" <bleal@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PULL 0/1] Fix for m68k/q800 acceptance test for QEMU 4.2-rc
Date: Fri, 6 Dec 2019 10:25:43 -0500 [thread overview]
Message-ID: <20191206152543.GA20588@dhcp-17-72.bos.redhat.com> (raw)
In-Reply-To: <CAFEAcA8ekevaZnwOg5bwJmkFkDFaC_qkrLLESLbSJs=L80viHA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]
On Fri, Dec 06, 2019 at 03:12:31PM +0000, Peter Maydell wrote:
> On Fri, 6 Dec 2019 at 15:09, Cleber Rosa <crosa@redhat.com> wrote:
> >
> > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:
> >
> > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000)
> >
> > are available in the Git repository at:
> >
> > git://github.com/clebergnu/qemu.git tags/python-next-pull-request
> >
> > for you to fetch changes up to 820649aa00ee343a0d473ad1002c59c70ba8c158:
> >
> > tests/boot_linux_console: Fetch assets from Debian snapshot archives (2019-12-06 09:48:35 -0500)
> >
> > ----------------------------------------------------------------
> > Fix for m68k/q800 acceptance test (Philippe Mathieu-Daudé)
>
> Any pullreq after about rc2 needs to clearly say
> what it's fixing and why it's justifiable for it to
> go in rather than waiting for the next release.
> Otherwise you get the default response:
> nope, not at this point in the release cycle.
>
> thanks
> -- PMM
>
Hi Peter,
This is fixing the URL from which a kernel package is fetched from,
updating it to an archival (thus stable) location. The current
location is transient, and Debian removes packages from those
locations after a given amount of time. Without this patch, the test
is never going to be executed. The package itself is unchanged, as
can be seen from the verification hash that was not changed.
While this is far from critical, the main benefit of having this in
4.2, as opposed to in the next cycle, is to not "ship" a broken test
in a release. It would also help downstream packages running such
tests.
And sorry for not giving the complete explanation before.
Thanks,
- Cleber.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-06 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 15:08 [PULL 0/1] Fix for m68k/q800 acceptance test for QEMU 4.2-rc Cleber Rosa
2019-12-06 15:08 ` [PULL 1/1] tests/boot_linux_console: Fetch assets from Debian snapshot archives Cleber Rosa
2019-12-06 15:12 ` [PULL 0/1] Fix for m68k/q800 acceptance test for QEMU 4.2-rc Peter Maydell
2019-12-06 15:25 ` Cleber Rosa [this message]
2019-12-06 15:37 ` Peter Maydell
2019-12-06 15:45 ` Cleber Rosa
2019-12-06 16:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206152543.GA20588@dhcp-17-72.bos.redhat.com \
--to=crosa@redhat.com \
--cc=bleal@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).