* [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()
@ 2019-12-07 9:48 Philippe Mathieu-Daudé
2019-12-07 13:44 ` Gavin Shan
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-07 9:48 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel
Cc: Marc-André Lureau, Philippe Mathieu-Daudé, Gavin Shan,
Eduardo Habkost, Igor Mammedov
There is no declaration of the 'NMI' type. INTERFACE_CHECK()
returns an abstract type (see commit aa1b35b975d8). The abstract
type corresponding to the TYPE_NMI interface is 'NMIState'.
Fixes: 9cb805fd267
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/nmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/nmi.h b/include/hw/nmi.h
index a1e128724e..fe37ce3ad8 100644
--- a/include/hw/nmi.h
+++ b/include/hw/nmi.h
@@ -31,7 +31,7 @@
#define NMI_GET_CLASS(obj) \
OBJECT_GET_CLASS(NMIClass, (obj), TYPE_NMI)
#define NMI(obj) \
- INTERFACE_CHECK(NMI, (obj), TYPE_NMI)
+ INTERFACE_CHECK(NMIState, (obj), TYPE_NMI)
typedef struct NMIState NMIState;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()
2019-12-07 9:48 [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK() Philippe Mathieu-Daudé
@ 2019-12-07 13:44 ` Gavin Shan
2019-12-13 20:08 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Gavin Shan @ 2019-12-07 13:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Alexey Kardashevskiy, qemu-devel
Cc: Marc-André Lureau, Eduardo Habkost, Igor Mammedov
On 12/7/19 8:48 PM, Philippe Mathieu-Daudé wrote:
> There is no declaration of the 'NMI' type. INTERFACE_CHECK()
> returns an abstract type (see commit aa1b35b975d8). The abstract
> type corresponding to the TYPE_NMI interface is 'NMIState'.
>
> Fixes: 9cb805fd267
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> include/hw/nmi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/nmi.h b/include/hw/nmi.h
> index a1e128724e..fe37ce3ad8 100644
> --- a/include/hw/nmi.h
> +++ b/include/hw/nmi.h
> @@ -31,7 +31,7 @@
> #define NMI_GET_CLASS(obj) \
> OBJECT_GET_CLASS(NMIClass, (obj), TYPE_NMI)
> #define NMI(obj) \
> - INTERFACE_CHECK(NMI, (obj), TYPE_NMI)
> + INTERFACE_CHECK(NMIState, (obj), TYPE_NMI)
>
> typedef struct NMIState NMIState;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()
2019-12-07 13:44 ` Gavin Shan
@ 2019-12-13 20:08 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2019-12-13 20:08 UTC (permalink / raw)
To: Gavin Shan
Cc: Alexey Kardashevskiy, Marc-André Lureau,
Philippe Mathieu-Daudé, qemu-devel, Igor Mammedov
On Sun, Dec 08, 2019 at 12:44:16AM +1100, Gavin Shan wrote:
> On 12/7/19 8:48 PM, Philippe Mathieu-Daudé wrote:
> > There is no declaration of the 'NMI' type. INTERFACE_CHECK()
> > returns an abstract type (see commit aa1b35b975d8). The abstract
> > type corresponding to the TYPE_NMI interface is 'NMIState'.
> >
> > Fixes: 9cb805fd267
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
Queued, thanks!
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-13 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-07 9:48 [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK() Philippe Mathieu-Daudé
2019-12-07 13:44 ` Gavin Shan
2019-12-13 20:08 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).